Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Set up your routes" example needs routes #4

Closed
jbence opened this issue Aug 28, 2017 · 2 comments
Closed

"Set up your routes" example needs routes #4

jbence opened this issue Aug 28, 2017 · 2 comments

Comments

@jbence
Copy link

jbence commented Aug 28, 2017

In the "Set up your routes, and serve them" example on http://mi.cro.services/, the $app variable is created, but not referenced after that. It should probably be passed to the Cro::HTTP::Server.new constructor:

:host<localhost>, :port<10000>, :application($app);

At least, doing this allowed the example to work OK on Windows 10.

@Altai-man
Copy link
Member

Thanks!

Fixed in development version, we'll serve updated site as soon as possible.

@Altai-man
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants