Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release perhaps? #542

Closed
svenstaro opened this issue Mar 26, 2021 · 26 comments
Closed

New release perhaps? #542

svenstaro opened this issue Mar 26, 2021 · 26 comments
Labels
Milestone

Comments

@svenstaro
Copy link
Contributor

Hey, the latest release is almost a year old by now and a few cool things have landed in master. Perhaps it's time for a new release?

@UebelAndre
Copy link
Contributor

I too would like to see a new release which includes #543

@reitermarkus would you be able to do this?

@reitermarkus
Copy link
Member

Feel free to send a PR with a version bump and changelog update.

@svenstaro
Copy link
Contributor Author

I suggest using cargo-release for stuff like this which will basically automate all of that away for you so you can only type cargo release and have even the CHANGELOG be generated for you. :)

@Dylan-DPC-zz
Copy link

Tbh i prefer doing it manually, ensures we haven't overlooked anything or included any breaking changes by mistake. (Also getting publishing rights would be nice ;) )

@reitermarkus
Copy link
Member

CI should be set up to do everything automatically when a tag is pushed

@reitermarkus
Copy link
Member

… except the changelog part.

@UebelAndre
Copy link
Contributor

Does anyone have bandwidth to throw together that PR? 🙏

@UebelAndre
Copy link
Contributor

@adamgreig @burrbull @Emilgardis @reitermarkus @ryankurte @therealprof
Sorry for pinging the entire tools team, but would any of you be able to create and merge a PR for a new release? 🙏

@therealprof
Copy link
Contributor

therealprof commented Apr 20, 2021

It's a bit unfortunate that the CHANGELOG is not continuously maintained. Otherwise a release wouldn't be a big deal.

Edit: I've just created PR #552 to reduce that pain for the future.

I haven't been paying too much attention to cross lately so I'm very likely to miss something if I were to create a CHANGELOG. Any volunteers?

@UebelAndre
Copy link
Contributor

I'm brand new to this repo but I do think my change (#543) might be a good one to go in the change log.

@rawkode
Copy link
Contributor

rawkode commented May 21, 2021

Waiting on #543 too 😅

@lpil
Copy link

lpil commented Jun 15, 2021

Hello all! It would be fantastic to get a release out as #543 is needed to fix my build and is currently blocking releases. Thank you

@Emilgardis
Copy link
Member

There are some standing issues with this version, namely changelog and windows support (that is, cross doesn't work on windows anymore).

There will be an announcement posted where we want more eyes on this codebase.

bors bot added a commit that referenced this issue Jun 20, 2021
559: fix: update changelog for pending release r=adamgreig a=rawkode

Changelog update


cc #542 

Co-authored-by: David McKay <david@rawkode.com>
Co-authored-by: Adam Greig <adam@adamgreig.com>
@adamgreig
Copy link
Member

We've also posted a call for help in #574 asking for assistance with maintenance and getting a new release out the door.

bors bot added a commit that referenced this issue Aug 4, 2021
559: fix: update changelog for pending release r=adamgreig a=rawkode

Changelog update


cc #542 

Co-authored-by: David McKay <david@rawkode.com>
Co-authored-by: Adam Greig <adam@adamgreig.com>
svenstaro pushed a commit to svenstaro/cross that referenced this issue Aug 29, 2021
559: fix: update changelog for pending release r=adamgreig a=rawkode

Changelog update

cc cross-rs#542

Co-authored-by: David McKay <david@rawkode.com>
Co-authored-by: Adam Greig <adam@adamgreig.com>
@svenstaro
Copy link
Contributor Author

So with the CHANGELOG change merged, how are we looking for a release?

@svenstaro
Copy link
Contributor Author

@adamgreig ping

@UebelAndre
Copy link
Contributor

@Emilgardis with CI now unblocked, would it be possible to get a new release? 😅 🙏

@Emilgardis
Copy link
Member

haha, no, what I meant with CI being crippled is that we basically have no CI now 😁 need to get #609 up and running to actually publish the changes in the images

@Emilgardis
Copy link
Member

Should we do a release and fix Windows in a later version? I think that's the only remaining issue now that CI is fixed

@svenstaro
Copy link
Contributor Author

I think it would be prudent to make a release now and figure out any remaining problems later at any rate.

@Emilgardis
Copy link
Member

Windows support has been fixed and CI is up and well.

I think the only (new) issue left is #683

@abrisco
Copy link

abrisco commented Apr 25, 2022

@Emilgardis hey, thanks for all the work on the project! Was wondering, what the outstanding blockers were to creating a new release?

@Emilgardis
Copy link
Member

Emilgardis commented Apr 25, 2022

I have one last concern with the x86_64-unknown-linux-gnu now being centos, but I think we're set to make a release.

This release would update a lot of workflows using cross in CI, especially those that use actions-rs, so it'd be good to make sure we're all set and everything is correct and that we don't break any assumptions, even though this would be a semver break.

It'd be nice if we could test this new release in CI, to do so yourself with GHA, you can just install cross manually before running the action that uses cross: run: cargo install cross --git https://github.com/cross-rs/cross

@abrisco
Copy link

abrisco commented May 20, 2022

@Emilgardis hello again. Is there a tracking issue or PR for the outstanding work?

@Emilgardis
Copy link
Member

the issue with x86_64-unknown-linux-gnu is #680, im still not sure we know how to best proceed

@Alexhuszagh Alexhuszagh added this to the v0.2.2 milestone May 29, 2022
@Emilgardis
Copy link
Member

We've now released v0.2.2, thank you everyone for your involvement and patience!

Full list of changes can be found on the release page. Read the README and wiki for guidance.

#857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests