Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error/panic on fallback to host cargo or when in CI environment #659

Closed
Emilgardis opened this issue Mar 17, 2022 · 2 comments · Fixed by #661
Closed

error/panic on fallback to host cargo or when in CI environment #659

Emilgardis opened this issue Mar 17, 2022 · 2 comments · Fixed by #661
Milestone

Comments

@Emilgardis
Copy link
Member

cross/src/main.rs

Lines 344 to 350 in eaeff5b

let image_exists = match docker::image(&config, &target) {
Ok(_) => true,
Err(err) => {
eprintln!("Warning: {} Falling back to `cargo` on the host.", err);
false
}
};

@jpmckinney
Copy link

jpmckinney commented Nov 26, 2022

I would also like an option to error/panic on fallback. This is especially useful in CI. I guess for now I can try to capture stderr and the exit code (edit: after trying a few different things, I haven't found a way for GitHub Actions output to be informative while still capturing some streams).

@Emilgardis
Copy link
Member Author

thats something I hadn't considered, maybe providing a way to not allow any warnings would be helpful.

We definitely want this included in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants