Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amp): update promtheusservice rulegroupsnamespace #1482

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

r0mdau
Copy link
Contributor

@r0mdau r0mdau commented Sep 19, 2022

Signed-off-by: Romain Dauby romain.dauby@gmail.com

Description of your changes

Updated prometheusservice/amp RuleGroupsNamespace resource with the custom update feature.

Fixes #1480

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

$ k apply -f examples/prometheusservice/workspace.yaml 
workspace.prometheusservice.aws.crossplane.io/example created

$ k get workspace
NAME      READY   SYNCED   EXTERNAL-NAME
example   True    True     ws-651f2dfc-8750-4115-82d9-8d1d2bfa3b9b

$ k apply -f examples/prometheusservice/rulegroupsnamespace.yaml 
rulegroupsnamespace.prometheusservice.aws.crossplane.io/example-rule created
$ k get rulegroupsnamespace
NAME           READY   SYNCED   EXTERNAL-NAME
example-rule   True    True     arn:aws:aps:us-east-1:015890463774:rulegroupsnamespace/ws-651f2dfc-8750-4115-82d9-8d1d2bfa3b9b/example-rule

$ k apply -f examples/prometheusservice/5m-rulegroupsnamespace.yaml

image

Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
@r0mdau
Copy link
Contributor Author

r0mdau commented Sep 19, 2022

The code generation make generate is replacing manually edited code.

I don't know if we should update the code generator or make exceptions in this project Makefile targets. As mentionned in the CODE_GENERATION.md documentation we can make manual edits for Update actions.

Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haarchri haarchri merged commit 6d69baf into crossplane-contrib:master Sep 19, 2022
@r0mdau r0mdau deleted the rulegroupsnamespace-update branch September 20, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheusservice rulegroupsnamespace does not support update
2 participants