Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same name as examples for ProviderConfig #1486

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

r0mdau
Copy link
Contributor

@r0mdau r0mdau commented Sep 20, 2022

Signed-off-by: Romain Dauby romain.dauby@gmail.com

Description of your changes

Minor fix on the CODE_GENERATION documentation.

While contributing to #1482 I encountered non working examples because the provider is not labeled example.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

N/A

Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the documentation

@haarchri haarchri merged commit 2a60f0a into crossplane-contrib:master Sep 22, 2022
@r0mdau r0mdau deleted the codegen_doc branch September 22, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants