Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds/docdb: ParameterGroup in update loop bc of applyMethod #1708

Closed
wotolom opened this issue Mar 28, 2023 · 0 comments · Fixed by #1709
Closed

rds/docdb: ParameterGroup in update loop bc of applyMethod #1708

wotolom opened this issue Mar 28, 2023 · 0 comments · Fixed by #1709
Labels
bug Something isn't working

Comments

@wotolom
Copy link
Contributor

wotolom commented Mar 28, 2023

What happened?

affecting RDS + DocDB: resources DBParameterGroup, DBClusterParametergroup

AWS seems to only consider changes to the field ApplyMethod, if the ParameterValue changes too.
This results in the controller constantly doing update calls.

I will provide a PR shortly.

How can we reproduce it?

example for DBParameterGroup:

apiVersion: rds.aws.crossplane.io/v1alpha1
kind: DBParameterGroup
metadata:
  name: example-dbparametergroup
spec:
  forProvider:
    region: us-east-1
    dbParameterGroupFamilySelector:
      engine: postgres
    description: "this applyMethod: immediate will not be set. AWS will only change it when parameterValue changes too "
    parameters:
      - applyMethod: immediate # immediate pending-reboot
        parameterName: rds.force_ssl
        parameterValue: "0"
  providerConfigRef:
    name: example

What environment did it happen in?

  • Crossplane version: 1.11.1
  • Provider-aws version: v0.38.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant