Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update crossplane-runtime to 1.14.1 #1935

Merged

Conversation

MisterMX
Copy link
Collaborator

@MisterMX MisterMX commented Nov 3, 2023

Description of your changes

  • Update controller-runtime and other libs as well.
  • Remove deprecated property spec.providerRef from all CRDs

Fixes: #1934

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

n.a.

* Update controller-runtime and other libs as well.
* Remove deprecated property `spec.providerRef` from all CRDs

Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
@MisterMX MisterMX force-pushed the chore/crossplane-runtime-1.14.1 branch from 96d600a to 3693b47 Compare November 3, 2023 12:35
@chlunde
Copy link
Collaborator

chlunde commented Nov 3, 2023

How has this code been tested
n.a.

I wonder if we could have a basic e2e/integration test that installs the previous version in a kind cluster, add some resources connected to local stack, upgrade and do some basic changes

@MisterMX
Copy link
Collaborator Author

MisterMX commented Nov 3, 2023

I wonder if we could have a basic e2e/integration test that installs the previous version in a kind cluster, add some resources connected to local stack, upgrade and do some basic changes

I know what you mean. We are thinking about a solution for this issue for quite a while already. Thing is that local stack only provides a subset of AWS resources and some of them only in the premium tier.

We have this integration test kinda thing in cluster/local/integration_tests.sh but it only tries to install the provider in a kind cluster and does not test the individual controllers.

There is a proposal in crossplane-contrib/provider-argocd#89 that uses
https://github.com/maximilianbraun/xp-testing and https://github.com/kubernetes-sigs/e2e-framework/ to run E2E tests. However, it is much simpler there because you only need an ArgoCD instance instead of a whole AWS environment.

@chlunde
Copy link
Collaborator

chlunde commented Nov 7, 2023

@MisterMX I was just thinking about testing a couple of services to get coverage for crossplane-runtime etc. Probably at least one service "hand written" and one generated, not full e2e coverage.

@MisterMX MisterMX merged commit 535f8f2 into crossplane-contrib:master Nov 7, 2023
9 checks passed
@MisterMX MisterMX deleted the chore/crossplane-runtime-1.14.1 branch November 7, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod restart due to "fatal error: concurrent map iteration and map write"
2 participants