fix: readd missed empty initializers after tagging removal #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
|
Successfully created backport PR #1948 for |
wotolom
deleted the
fix-readd-empty-initializers-after-tagging-removal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Similar to #1942, this fixes - hopefully all - missed cases where the empty
managed.WithInitializers()is needed.My guess is that resources, that where only affected through #1938 and not through #1935, were missed in #1942
acm.Certificate,acmpca.CertificateAuthority, andiam.Policyare actually not working (not possible to create new claims) in v0.45.0, due to AWS validating/expecting ARNs in Describe/Get requests.iam.OpenIDConnectProviderprobably also, did not manually test here.ec2.TransitGatewayVPCAttachmentandec2.VPCPeeringConnectionseem to be fine currently, as AWS is not validating IDs.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested