fix: Readd empty initializers after runtime update #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
force-pushed
the
fix/runtime-upgrade-initializers
branch
from
2b3dfca
to
4bf35a1
Compare
|
I think this CI will be green if rebased? |
chlunde
approved these changes
Nov 9, 2023
The default behaviour of a controller is to use `managed.NewNameWithExternalName`. Controllers need to pass `managed.WithInitializers()` to change the behaviour. After the runtime upgrade and tagging removal, some of the empty `managed.WithInitializers()` got removed resulting in a different behaviour. Readd them restore the previous behaviour. Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
fix/runtime-upgrade-initializers
branch
from
4bf35a1
to
0ddc4ec
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The default behaviour of a controller is to use
managed.NewNameWithExternalName. Controllers need to passmanaged.WithInitializers()to change the behaviour.After the runtime upgrade and tagging removal, some of the empty
managed.WithInitializers()got removed resulting in a different behaviour.Readd them restore the previous behaviour.
Partially reverts #1935.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
No, testing was performed. Just comparison to the previous version.