Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSN's that don't exist #37

Closed
sckott opened this issue Dec 19, 2014 · 5 comments
Closed

ISSN's that don't exist #37

sckott opened this issue Dec 19, 2014 · 5 comments
Labels

Comments

@sckott
Copy link

sckott commented Dec 19, 2014

Whenever an ISSN is not found/doesn't exist, the same result returns. For example:

http://api.crossref.org/journals/asdfasfaslfjsajaslfasjjksladf

gives a result, where the ISSN value is "".

Is this by design? I would think that asdfasfaslfjsajaslfasjjksladf would return a 404 maybe?

@sckott
Copy link
Author

sckott commented Dec 19, 2014

hmmm, I get the same problem with the /works endpoint, e.g., http://api.crossref.org/works/23094829048209249208424 in which DOI=""

@kjw
Copy link
Contributor

kjw commented Dec 19, 2014

Definitely not by design. There's practically no input validation and the code that tries to normalize ISSNs and DOIs is somehow making something out of the strings you are providing rather than causing things to error.

Fix coming in the input validation work.

@kjw kjw added the bug label Dec 19, 2014
@sckott
Copy link
Author

sckott commented Dec 19, 2014

@kjw Thanks! I realize that something like asdfasfaslfjsajaslfasjjksladf is not a proper ISSN, DOI, etc. but I'm trying to account for the various things users could pass to parameters

@kjw
Copy link
Contributor

kjw commented Feb 9, 2016

Now results in 404.

@kjw kjw closed this as completed Feb 9, 2016
@sckott
Copy link
Author

sckott commented Feb 9, 2016

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants