This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Extensions] Build glib message pump on Ozone #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing patch series with a364bf9 as its head.
|
@tmpsantos you need to rebase the patch now that we have moved to M36. I guess it still applies. |
The GLib mainloop is a nice to have on the Extension Process (only) to ease the integration with DBus based services. The patch won't make glib the default, but will make it possible to use it if explicitly declared.
Testing patch series with 1687714 as its head.
|
@darktears rebased |
darktears
added a commit
that referenced
this pull request
Jun 9, 2014
[Extensions] Build glib message pump on Ozone
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
BUG=404063 Review URL: https://codereview.chromium.org/474163002 Cr-Commit-Position: refs/heads/master@{#290212} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290212 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 61a8527) Review URL: https://codereview.chromium.org/532433002 Cr-Commit-Position: refs/branch-heads/2125@{#160} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
…Status pb BUG=421210 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/635093002 Cr-Commit-Position: refs/heads/master@{#298771} (cherry picked from commit 3689f8d) Review URL: https://codereview.chromium.org/658223003 Cr-Commit-Position: refs/branch-heads/2171@{#160} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
Setting the default id causes the regression crbug.com/450095, so this patch removes it. BUG=450095 TEST=manually tested TBR=yoshiki@chromium.org Review URL: https://codereview.chromium.org/810483005 Cr-Commit-Position: refs/heads/master@{#312182} (cherry picked from commit f97f8f3) Review URL: https://codereview.chromium.org/893533004 Cr-Commit-Position: refs/branch-heads/2272@{#160} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
Also make sure that default hide callback does nothing if parent screen was not set. Follow up to a refactoring https://codereview.chromium.org/872633008/ BUG=462453 TEST=manually, existing browser tests Review URL: https://codereview.chromium.org/982823004 Cr-Commit-Position: refs/heads/master@{#319282} (cherry picked from commit ddb237a) R=nkostylev@chromium.org Review URL: https://codereview.chromium.org/987693002 Cr-Commit-Position: refs/branch-heads/2311@{#160} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
This CL adds methods to check for horizontal size class of views, view controllers, etc. BUG=527404 R=justincohen@chromium.org,rohitrao@chromium.org Review URL: https://codereview.chromium.org/1329713002 Cr-Commit-Position: refs/heads/master@{#347211} (cherry picked from commit ab73901) TBR=justincohen@chromium.org,rohitrao@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1321533006 Cr-Commit-Position: refs/branch-heads/2490@{#160} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
…eral API This CL replaces CronetEngine.Builder#setExperimentalQuicConnectionOptions with a more general API to set experimental options. BUG=545118 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1414053008 Cr-Commit-Position: refs/heads/master@{#360187} (cherry picked from commit 61b1eaa) Review URL: https://codereview.chromium.org/1487723002 Cr-Commit-Position: refs/branch-heads/2564@{#160} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
… Service Workers. Merge to 2623 of crrev.com/1544863002. Service Workers are not tied to AwContents as regular webviews are and therefore do not invoke callbacks provided in WebViewClient and WebChromeClient. This patch provides initial implementation of AwServiceWorkerClient, AwServiceWorkerSettings and related infrastructure. In particular it implements the shouldInterceptRequest callback mechanism for service worker related requests. The callback is invoked when a service worker script is registered and also for network fetches from within the service worker script. This patch also contains a fix for TestWebServer to make it work with service workers. BUG=566027 TBR=mnaganov@chromium.org, torne@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1544863002 Cr-Commit-Position: refs/heads/master@{#370998} (cherry picked from commit 47612e4) Review URL: https://codereview.chromium.org/1638393002 . Cr-Commit-Position: refs/branch-heads/2623@{#160} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Merging to M50 This CHECK fires intermittently and appears to be caused by buggy drivers and or AV malware combinations. In most of the crashes, I debugged, the failure was MF_E_INVALIDMEDIATYPE which indicates that the driver does not support H.264 decoding. In any case this code has now baked for a while on the field for DX11 and Win8+. So it should be ok to remove the CHECK BUG=588358 R=sandersd Review URL: https://codereview.chromium.org/1770223002 Cr-Commit-Position: refs/heads/master@{#379704} (cherry picked from commit 61b99f6) Review URL: https://codereview.chromium.org/1775613005 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#160} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Implements BrowserWindowCocoa::ShowNewBackShortcutBubble to open the Views implementation of this bubble (similar to how the fullscreen bubble works on Mac). BUG=610039 Review-Url: https://codereview.chromium.org/2017813004 Cr-Commit-Position: refs/heads/master@{#396759} (cherry picked from commit d8fdd17) Review URL: https://codereview.chromium.org/2020273003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#160} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This patch fixes a crash that can occur if a tab is closed while the Location Settings Dialog is open (it's modal but doesn't block JS). The GeolocationServiceImpl correctly cancels permission requests upon upon destruction so it should be able to use an Unretained callback into itself for permission requests, but we end up binding this to the LSD completion callback and not clearing it upon cancels. TBR=timloh@chromium.org (cherry picked from commit a7a788f) Bug: 754376 Change-Id: I81bcdf2fb0c71821b1cfa83fdf1caff1449f360b Reviewed-on: https://chromium-review.googlesource.com/644592 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499597} Reviewed-on: https://chromium-review.googlesource.com/662717 Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#160} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GLib mainloop is desired on the Extension Process (only) to ease
the integration with DBus based services.
The patch won't make glib the default, but will make it possible to use
it if explicitly declared.