This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Backport][Windows] Pass "/MD" and variants outside the "runtime_library" target #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary" target
This patch is required for the .NET extension bridge to be built.
BUG=XWALK-7336
> Create separate configurations for passing "/MD", "/MT" and their debug
> variants: "dynamic_crt" passes "/MD" and "/MDd", whereas "static_crt"
> passes "/MT" and "/MTd". BUILDCONFIG then depends on "default_crt",
> which has some logic to choose whether to use either dynamic_crt or
> static_crt.
>
> The main reason behind this is to allow users to config -= the
> "default_crt" config: in gyp, it was possible to configure what was
> going to be passed to the compiler via the
> "win_{release,debug}_RuntimeLibrary" variable, which was useful when
> building code that needs to pass "/CLR", as it requires "/MD" and does
> not work with "/MT".
>
> R=brettw@chromium.org,dpranke@chromium.org,scottmg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2379573003
|
Testing patch series with rakuco/chromium-crosswalk@8596c69 as its head.
|
|
LGTM |
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Sep 30, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 5, 2016
rakuco
added a commit
to rakuco/crosswalk
that referenced
this pull request
Oct 7, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 7, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 11, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 11, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 13, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 13, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 14, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 15, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 17, 2016
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
TBR=dimu@chromium.org Change-Id: I117057c3659b246d02b7230122d9510b5ff9f396 Reviewed-on: https://chromium-review.googlesource.com/677974 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#385} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is required for the .NET extension bridge to be built.
RELATED BUG=XWALK-7336