This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Windows] GN: Add missing RSSDK files in media/. #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should be squashed into "[Windows] Support RealSense Cameras" in the future. It simply does the same thing in GN: a new argument `use_rssdk` has been added (defaulting to `false`) and takes care of selecting which RSSDK files to include. This is an improved version of a patch originally written by Ke He <ke.he@intel.com>.
|
Testing patch series with rakuco/chromium-crosswalk@f1476d3 as its head.
|
|
@darktears @heke123 |
|
LGTM |
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Sep 30, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 5, 2016
rakuco
added a commit
to rakuco/crosswalk
that referenced
this pull request
Oct 7, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 7, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 11, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 11, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 13, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 13, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 14, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 15, 2016
rakuco
added a commit
to crosswalk-project/crosswalk
that referenced
this pull request
Oct 17, 2016
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Remove form action check, only requres secure origin to trigger autofill query for WebView. Bug: 766302 Change-Id: I416a174904fe7b2adc16226d1b68fa94056a9ee5 Reviewed-on: https://chromium-review.googlesource.com/671803 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502901}(cherry picked from commit 6b032dd) Reviewed-on: https://chromium-review.googlesource.com/677641 Reviewed-by: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#386} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should be squashed into "[Windows] Support RealSense
Cameras" in the future. It simply does the same thing in GN: a new
argument
use_rssdkhas been added (defaulting tofalse) and takescare of selecting which RSSDK files to include.
This is an improved version of a patch originally written by Ke He
ke.he@intel.com.