This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Windows] Maximize the window over the taskbar in the fullscreen mode. #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with joone/crosswalk@b25a9b7 as its head.
|
It allows the users to close the fullscreen application. This is a temporary solution. Metro driver will be used to make Crosswalk applications work like Windows universal application, which is in src/win8/metro_driver of Chromium source code. BUG=XWALK-4861
joone
force-pushed
the
xwalk-4861.fullscreen
branch
from
b25a9b7
to
56773e4
Compare
|
Testing patch series with joone/crosswalk@56773e4 as its head.
|
| // Set ui::SHOW_STATE_MAXIMIZED instead of ui::SHOW_STATE_FULLSCREEN | ||
| // because there is no way to exit from full screen mode. | ||
| // Refer to XWALK-4861 for more details. | ||
| #if defined(OS_WIN) |
There was a problem hiding this comment.
looks like it breaks fullscreen on linux desktop
|
What's the status of this pull request? |
|
@joone ??? |
|
We don't need this commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows the users to close the fullscreen application.
BUG=XWALK-4861