This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Windows] Maximize the window over the taskbar in the fullscreen mode. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#369}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…dow display as an inactive window. The expectation is that we should dismiss the bubble on activities like mouse down, touch down, on the anchor window as well. The FirstRunBubbleCloser class now observes the native view instead of the root view as the latter does not work if we have mouse and touch events on the RWHVA. BUG=555416 TEST=Covered by tests FirstRunBubbleTest.CloseBubbleOnMouseDownEvent and FirstRunBubbleTest.CloseBubbleOnTouchDownEvent Review URL: https://codereview.chromium.org/1443253004 Cr-Commit-Position: refs/heads/master@{#359902} (cherry picked from commit 50a8b1f) Review URL: https://codereview.chromium.org/1534653002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#370} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Sometimes the DownloadService will call showSnackbars() even when the activity is not visible. To track the activity's visibility, SnackbarManager now needs to know some activity's lifecycle signals. After this CL, all activities managing snackbars should call onStart and onStop of the SnackbarManager. BUG=553569 TBR=newt@chromium.org Review URL: https://codereview.chromium.org/1518373002 Cr-Commit-Position: refs/heads/master@{#365751} Review URL: https://codereview.chromium.org/1526313003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#371} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Unlike other platforms, ChromeOS does not trigger ProfileOAuth2TokenService#LoadCredentials(). As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded notification before fetching the account info. This cl ensures that notification is triggered correctly in the simplest way. However this should ideally be handled within the OAuth2TokenServiceDelegate or plumbed in a more explicit manner. BUG=557906 NOTRY=true Review URL: https://codereview.chromium.org/1523743003 Cr-Commit-Position: refs/heads/master@{#365491} (cherry picked from commit 91d55c6) Review URL: https://codereview.chromium.org/1533643004 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#372} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…ts, listen for messages sooner. CastRouteController now sends messages to the route id associated with the client id, mMediaRouteId was removed. Also PresentationDispatcher subscribes to the PresentationConnection messages before passing the new connection to the page. BUG=569601 TEST=manually run all previously passing Cast e2e tests with the newly passing auto-join test. Review URL: https://codereview.chromium.org/1522313003 Cr-Commit-Position: refs/heads/master@{#365635} (cherry picked from commit 25472ea) Review URL: https://codereview.chromium.org/1538493002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#373} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…r vs chooser dialog Historically, logic relied on having just one route at all. Now that there might be many routes per connection, if there's a known route with the same source id, we show the chooser dialog, otherwise the picker dialog. BUG=570448 TEST=Manual+e2e tests Review URL: https://codereview.chromium.org/1534553002 Cr-Commit-Position: refs/heads/master@{#365654} (cherry picked from commit 9a35760) Review URL: https://codereview.chromium.org/1527353003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#374} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
The GaiaAuthFetcher Logout call needs Account Consistency to be disabled to work properly. On iOS, the state of Account Consistency is handled by cookies set on the various Google domains. Sadly, the cookie clearing request is not synchronized with the Logout call and there is a race between the two. This CL forces the cookie to be invalid during the Logout request to ensure the accounts will be cleared. The cookie will eventually be invalidated in the WKWebView cookie jar when AccountConsistencyService finishes. BUG=569501 Review URL: https://codereview.chromium.org/1522873002 Cr-Commit-Position: refs/heads/master@{#365248} (cherry picked from commit def2982) Review URL: https://codereview.chromium.org/1536663003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#375} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This was caused by: https://codereview.chromium.org/1250403002 That CL moved where command validation happened, but the new handler wasn't hooked up to the full screen window that gets opened on 10.6. Note: The 10.6 behavior can be simulated by changing the return value of SupportsSystemFullscreen() to false. BUG=569418 TEST=On Mac OS 10.6, check that cmd-shift-F can toggle full screen back and forth. Review URL: https://codereview.chromium.org/1520283003 Cr-Commit-Position: refs/heads/master@{#365375} (cherry picked from commit 4d1e70c) Review URL: https://codereview.chromium.org/1534753003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#376} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=570337 R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/1531823002 Cr-Commit-Position: refs/heads/master@{#365569} (cherry picked from commit 34cf3eb) Review URL: https://codereview.chromium.org/1532933002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#377} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
For R48, On chrome book we found when doing screen share of the whole screen, the mouse cursor was not captured. This is caused by a bug we consider the root window as inactive. In this CL, we fix this bug, and then mouse cursor is shared when doing full screen share. BUG=568841 Review URL: https://codereview.chromium.org/1527603005 Cr-Commit-Position: refs/heads/master@{#365594} (cherry picked from commit 65a833a) Review URL: https://codereview.chromium.org/1538623002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#378} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This change removes the logic from the close button that disables the Reader Mode panel for a particular tab. Now refreshing the page will reshow the panel. BUG=570407 Review URL: https://codereview.chromium.org/1514603004 Cr-Commit-Position: refs/heads/master@{#364459} (cherry picked from commit b1da094) Review URL: https://codereview.chromium.org/1535783002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#379} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=570407 Review URL: https://codereview.chromium.org/1509953006 Cr-Commit-Position: refs/heads/master@{#364819} (cherry picked from commit 889534f) Review URL: https://codereview.chromium.org/1538563003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#380} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
The animation between peeking and maximized states is too fast. This change adds 200ms to that animation duraton. BUG=570407 Review URL: https://codereview.chromium.org/1511023003 Cr-Commit-Position: refs/heads/master@{#364428} (cherry picked from commit 2040edb) Review URL: https://codereview.chromium.org/1538583003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#381} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…e currently it breaks Flash content. Added a fix so that the flash content is ensured to take up the entire fullscreen window when it enters fullscreen. BUG=566588 Review URL: https://codereview.chromium.org/1526533005 Cr-Commit-Position: refs/heads/master@{#365293} (cherry picked from commit b97a851) Review URL: https://codereview.chromium.org/1537843002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#382} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=561470 TEST=manual with the YT experiment 1. Allow a route with a special presentation id to join a non-existing session to pass the CAST message back through. 2. Send the CAST message back via the special route before the route is being created with the selected device info. 3. Send the STOP message via the normal route when the session is about to close via the CloseRoute() or the notification controls. Review URL: https://codereview.chromium.org/1534783002 Cr-Commit-Position: refs/heads/master@{#365900} (cherry picked from commit e96721f) Review URL: https://codereview.chromium.org/1532193002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#383} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
TBR=michaeln,mmenke BUG=567692 Committed-First-Time: https://crrev.com/ebf7a6b19a7a468195a5606fbd2bbd6d07a26ea2 Cr-Commit-Position-First-Time: refs/heads/master@{#365177} Review URL: https://codereview.chromium.org/1513783005 Cr-Commit-Position: refs/heads/master@{#365316} (cherry picked from commit f01c122) Conflicts: content/browser/loader/upload_data_stream_builder.cc Review URL: https://codereview.chromium.org/1539693003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#384} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Statically-linked binaries do not need -rpath=$ORIGIN set, and setting it can be a source of strange security issues (see bug for more details). Manually add this to some test binaries that require shared libraries to be loaded from the build directory. R=phajdan.jr@chromium.org, thestig@chromium.org BUG=556843 Renald of https://codereview.chromium.org/1525733002/ TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1525773002 Cr-Commit-Position: refs/heads/master@{#365125} (cherry picked from commit 5e63330) Review URL: https://codereview.chromium.org/1535863002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#385} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
The ContentViewClient responsible for setting the width of the panel content in Contextual Search is now set is the OverlayPanel. BUG=568616, 560130 Review URL: https://codereview.chromium.org/1514603007 Cr-Commit-Position: refs/heads/master@{#365420} (cherry picked from commit 37c3add) Review URL: https://codereview.chromium.org/1532793003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#386} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#387}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Add fullscreen checks to the ContentViewClient responsible for sizing the ContentViewCore. BUG=568616, 560130 Review URL: https://codereview.chromium.org/1537733002 Cr-Commit-Position: refs/heads/master@{#365940} (cherry picked from commit cbdf827) Review URL: https://codereview.chromium.org/1534913004 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#388} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA statistics gathering (first was https://codereview.chromium.org/1458783002). This CL calls the MediaStatistics::StopAndReport call from the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(), when the error detected and when the end of stream is detected, instead of calling it internally when the state machine went to the stopped state. By doing this we shall make MediaCodecPlayer behavior to be the same as the MediaSourcePlayer and do not record an artificial playback stop on internal event like starvation or resultion change with the decoder drain. This CL already eliminates an incorrect stop detection when the user switches to the fullscreen mode and back while playing. BUG=407577, 570835 TBR=timav > Review URL: https://codereview.chromium.org/1537583002 > Cr-Commit-Position: refs/heads/master@{#365967} Review URL: https://codereview.chromium.org/1532883004 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#389} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
The info.Holder() and info.This() can be totally different objects. Fixes [LenientThis] to refer to info.Holder() which is the correct receiver object. BUG=569043 Review URL: https://codereview.chromium.org/1526833003 Cr-Commit-Position: refs/heads/master@{#365748} (cherry picked from commit 6097f83) Review URL: https://codereview.chromium.org/1539813002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#390} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/DPFNigRT6Dc/5ck9egACBAAJ > A) What the specification defines; form.imageName where |imageName| is a > descendant of |form|. > > B) What the specification lacks, and all browsers agree; form.imageName where > |imageName| is not a descendant of |form| and is associated by HTML parser. > > C) WebKit-only quirk: form.elements.imageName This CL adds UseCounter::FormNameAccessForNonDescendantImageElement for B. UseCounter::FormControlsCollectionNameAccessForImageElement for C. BUG=570151 Review URL: https://codereview.chromium.org/1529033002 Cr-Commit-Position: refs/heads/master@{#365468} (cherry picked from commit dc1e9e5) Review URL: https://codereview.chromium.org/1535803003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#391} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
BUG=568139 Review URL: https://codereview.chromium.org/1505353007 Cr-Commit-Position: refs/heads/master@{#365223} (cherry picked from commit b66b8bd) Review URL: https://codereview.chromium.org/1532093005 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#392} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Additional M47/M48 only fix BUG=568602 R=torne@chromium.org TBR=atwilson@chromium.org Review URL: https://codereview.chromium.org/1535943003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#393} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Have RenderFrames export whether they are currently handling a paste, and have autofill save text that came from a paste. Pastes are not "user gestures" in the blink sense of the phrase, but pastes via InputMsg_Paste are always user- triggered. BUG=514636 Review URL: https://codereview.chromium.org/1488093002 Cr-Commit-Position: refs/heads/master@{#363232} (cherry picked from commit db20fae) Review URL: https://codereview.chromium.org/1537003002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#394} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
…llbars Due to other delayed layouts that may have happened in between, we may not need scrollbars anymore. R=szager@chromium.org,leviw@chromium.org BUG=560121 Review URL: https://codereview.chromium.org/1504923010 Cr-Commit-Position: refs/heads/master@{#365741} (cherry picked from commit 657bd17) Review URL: https://codereview.chromium.org/1532923004 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#395} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Add a maximum icon width for the ContextualSearchLayer and use it to center the static icon. The max icon size is in dp, so the current value of dp-to-px needs to be passed to native. BUG=570407 Review URL: https://codereview.chromium.org/1535753002 Cr-Commit-Position: refs/heads/master@{#365985} (cherry picked from commit fa69789) Review URL: https://codereview.chromium.org/1540613002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#396} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#397}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Adding subviews in layoutSubviews is problematic (see http://stackoverflow.com/questions/34301366/call-addsubview-within-layoutsubviews/34301753) This CL moves it out of |layoutSubviews| and into when the CRWWebViewContentView is actually set on the ContainerView. The existing logic will take care of removing the old ContentView from the superview when there is a need to replace the ContentView. As a (intended) side effect this CL fixes a bug in UIWebView where adding it as part of layoutSubViews would lead to issues in scrolling of certain pages. BUG=568097 TEST= Illustrated in the bug. Review URL: https://codereview.chromium.org/1531593002 Cr-Commit-Position: refs/heads/master@{#365691} (cherry picked from commit f5406c8) Review URL: https://codereview.chromium.org/1538093002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#398} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
|
Testing patch series with joone/chromium-crosswalk@04d1582 as its head.
|
|
This CL needs crosswalk-project/crosswalk#3501 |
joone
force-pushed
the
xwalk-4861.fullscreen
branch
from
04d1582
to
8f2c33c
Compare
|
Testing patch series with joone/chromium-crosswalk@8f2c33c as its head.
|
|
Why not just update #309? |
|
@rakuco I changed the local branch name. |
|
@pozdnyakov what do you think? It can be a compromise until we integrate better with the VM (which would require a lot more work on the views toolkit). |
It allows the users to close the fullscreen application. This is a temporary solution. Metro driver will be used to make Crosswalk applications work like Windows universal application, which is in src/win8/metro_driver of Chromium source code. BUG=XWALK-4861
joone
force-pushed
the
xwalk-4861.fullscreen
branch
from
8f2c33c
to
a894620
Compare
|
Testing patch series with joone/chromium-crosswalk@a894620 as its head.
|
|
This is a temporary solution. Metro driver will be used to make |
|
@joone @darktears but metro driver is a bit different case, right? For chromium it just provides CrOS session, how would it help with Crosswalk fullscreen apps? |
rakuco
force-pushed
the
master
branch
2 times, most recently
from
0f31e18
to
3da217c
Compare
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
… action. This adds a menu item to remove the MR component action from the toolbar. It sets a pref so this preference is respected across sessions. The user can restore the action by reinstalling the Cast extension from the Web Store. (They may have to reload the Web Store page immediately after installation to do so.) BUG=576362 TESTED=Unit test, manually tested Review URL: https://codereview.chromium.org/1612203002 Cr-Commit-Position: refs/heads/master@{#371629} (cherry picked from commit 95cfa83) Review URL: https://codereview.chromium.org/1679993002 . Cr-Commit-Position: refs/branch-heads/2623@{#311} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
… ripples. The Bookmark ripple was getting clipped on devices with a 2x scale factor due to the Canvas not being large enough. BUG=594243 TEST=manual Review URL: https://codereview.chromium.org/1806563002 Cr-Commit-Position: refs/heads/master@{#381232} (cherry picked from commit ce72fa9) Review URL: https://codereview.chromium.org/1820913003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#311} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei
pushed a commit
to fujunwei/chromium-crosswalk
that referenced
this pull request
May 27, 2016
LayoutManagerChrome now observes the TabModelSelector to see if any Incognito tabs exist during startup. If so, it signals to the Layout that the Incognito tab switcher button should be visible. BUG=543885 TBR=dtrainor Review URL: https://codereview.chromium.org/1514503002 Cr-Commit-Position: refs/heads/master@{#364225} Review URL: https://codereview.chromium.org/1506203009 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#311} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
The consequence is that the Promise returned by play() is rejected by the task created by pause(). The fix is to associate the tasks with a list of promises. BUG=593273 TBR=avayvod@chromium.org Review-Url: https://codereview.chromium.org/1865933002 Cr-Commit-Position: refs/heads/master@{#398370} (cherry picked from commit 3a82d82) Review URL: https://codereview.chromium.org/2053333002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#311} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Exported textures needs to be delete to not leak memory. This adds an ExportedTextureDeleter helper class that can be used to delete exported textures while still making sure the compositor had a chance to consume them. TBR=reveman@chromium.org (cherry picked from commit 869d134) Bug: 764007 Test: manual Change-Id: I18fa0494282f2352e73b320c05add8d944615213 Reviewed-on: https://chromium-review.googlesource.com/669586 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502518} Reviewed-on: https://chromium-review.googlesource.com/671872 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#311} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows the users to close the fullscreen application.
BUG=XWALK-4861