Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back checks for SLES12SP2 based repositories #2233

Closed
wants to merge 1 commit into from
Closed

Added back checks for SLES12SP2 based repositories #2233

wants to merge 1 commit into from

Conversation

jsuchome
Copy link
Member

@jsuchome jsuchome commented Jun 21, 2016

Added back checks for SLES12SP2 based repositories, to be used
when SLES12SP2 is the default. They were temporary removed in
commit bf5a372

when SLES12SP2 is the default. They were temporary removed in
commit bf5a372
@jsuchome jsuchome changed the title Added back checks for SLES12SP2 based repositories, to be used Added back checks for SLES12SP2 based repositories Jun 21, 2016
@rsalevsky
Copy link
Member

@jsuchome Is this still needed?

@jsuchome
Copy link
Member Author

jsuchome commented Oct 5, 2016

Seems like the code currently does not check for SP2 media, and we've switched already. So I'd say yes, this should be probably used...

@dirkmueller dirkmueller added this to the Cloud 7 GM milestone Jan 3, 2017
Copy link
Member

@vuntz vuntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with it as it is, although a small improvement would be welcome.

check_media_content \
SLES12-SP2 \
$MEDIA \
#b52c0f2b41a6a10d49cc89edcdc1b13d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to take the checksum from the final SP2 image here.

@vuntz vuntz self-assigned this Jan 6, 2017
@jsuchome
Copy link
Member Author

I've lost my original branch. Continued in #2304

@jsuchome jsuchome closed this Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants