Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Task API: new includePreTranslatedStringsOnly parameter #88

Closed
andrii-bodnar opened this issue Jun 27, 2023 · 6 comments · Fixed by #124
Closed

Create Task API: new includePreTranslatedStringsOnly parameter #88

andrii-bodnar opened this issue Jun 27, 2023 · 6 comments · Fixed by #124
Assignees
@OmAximani0
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

API Reference: Add Task

The API response will also include this new field.

This is relevant for both the crowdin.com and Crowdin Enterprise APIs.

The new parameter should also be reflected in this API client.
@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers labels Jun 27, 2023
@andrii-bodnar andrii-bodnar added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Sep 13, 2023
@OmAximani0
Copy link
Contributor

Hey @andrii-bodnar , assign to me please

@andrii-bodnar
Copy link
Member Author

Hey @OmAximani0, assigned

@OmAximani0
Copy link
Contributor

@andrii-bodnar For Add Task is there a function missing for the body CrowdinLanguageServiceTaskCreateFrom ? because I saw there are different functions for each body type.

@OmAximani0
Copy link
Contributor

And also I saw some missing params in add_vendor_oht_task is this for any reason or is just missed ?

@andrii-bodnar
Copy link
Member Author

@OmAximani0 thanks for noticing this!

It would be great to add these missing params and create a new method for CrowdinLanguageServiceTaskCreateFrom as well

@OmAximani0
Copy link
Contributor

Ok I'll add that in this issue referenced PR

@OmAximani0 OmAximani0 mentioned this issue Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmAximani0 OmAximani0

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support for includePreTranslatedStringsOnly OmAximani0/crowdin-api-client-python
2 participants
@andrii-bodnar @OmAximani0