Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing a new release to Pypi to remove extra debug statements in stdout? #106

Closed
ethan1uphealth opened this issue Mar 24, 2023 · 3 comments
Labels
fixed_in_develop Issues solved in develop branch but not yet in a release

Comments

@ethan1uphealth
Copy link

ethan1uphealth commented Mar 24, 2023

Hi,

I noticed when using the hlyapy v1.3.4 package from Pypi there are still some debug statements being output to stdout. It looks like this is coming from a print() statement in factories:102. In the develop branch, it looks like this extra print statement was removed in an earlier PR.

Is there a way someone could update the Pypi package to make it easier to get rid of those debug statements?

Thanks!

Example:

(000)000-0000 is not an HL7 valid NM value

@svituz
Copy link
Member

svituz commented Apr 12, 2023

Hi @ethan1uphealth,
we need to schedule a new release with some bug fixes and we'll take care of printing too.

@yankov-sdx
Copy link

Is there any chance a new release is going to come out with this print statement removed soon? I see potential for PHI to get printed out that should not appear in the logs. Planning on using a github branch as a work around in the mean time, but would be nice to be able to go pypi instead.

@svituz svituz added the fixed_in_develop Issues solved in develop branch but not yet in a release label Mar 13, 2024
@svituz
Copy link
Member

svituz commented Mar 13, 2024

Hi I released version 1.3.5

@svituz svituz closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed_in_develop Issues solved in develop branch but not yet in a release
Projects
None yet
Development

No branches or pull requests

3 participants