Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mip map generation #46

Merged
merged 38 commits into from
Jul 23, 2021
Merged

Mip map generation #46

merged 38 commits into from
Jul 23, 2021

Conversation

crud89
Copy link
Owner

@crud89 crud89 commented Jun 29, 2021 •
edited

This PR implements support for automatic mip map generation.

@crud89 crud89 added Priority: Medium A issue with normal priority. Type: Feature Request New feature or request. Type: Requirement An implementation is required before the next release. Status: In Progress Module: Vulkan 🌋 The issue involves the Vulkan backend. Module: DX12 ❎ The issue involves the DX12 backend. labels Jun 29, 2021
@crud89 crud89 added this to the Alpha #02 milestone Jun 29, 2021
@crud89 crud89 self-assigned this Jun 29, 2021
@crud89 crud89 linked an issue Jun 29, 2021 that may be closed by this pull request
Add support for mip-map generation. #40
Closed
@crud89
Copy link
Owner Author

crud89 commented Jul 4, 2021

Will continue implementation after #48 gets merged.

@crud89 crud89 linked an issue Jul 7, 2021 that may be closed by this pull request
Improve storage buffers. #51
Closed
@crud89 crud89 linked an issue Jul 8, 2021 that may be closed by this pull request
Decouple descriptors from resources #52
Closed
@crud89 crud89 marked this pull request as draft July 8, 2021 07:30
@crud89 crud89 changed the title WIP: Mip map generation Mip map generation Jul 8, 2021
crud89 added 22 commits July 20, 2021 18:18
@crud89
Merge branch 'mip-map-generation' of https://github.com/Aschratt/LiteFX…
629b6f2 
… into mip-map-generation
@crud89
Merge changes from main.
788d068
@crud89
Fix error that caused resizing not to properly update frame buffers.
de94c2c
@crud89
Removed IBindable and IConstantBuffer interfaces.
4e6cafd 
This also removes the conceptual dependency between buffers/textures and descriptor layouts.
@crud89
Implement decoupling between buffers/textures and descriptor layouts …
1ba474d 
…for Vulkan back-end.

Relates to #52.
This also implements #51 for Vulkan, though generic buffer writes still need to be tested.
@crud89
Don't run checks for draft PRs.
68e8063
@crud89
Attempt to fix name issue.
b5ba552
@crud89
Revert fix... guess we have to name with the weirdness when using dra…
cc6aa6d 
…ft PRs.
@crud89
Remove descriptor layout dependency from buffers and textures.
f6bede9 
Implements #52 for the DirectX 12 back-end.
@crud89
Convert descriptor types to respective buffer type.
609932b
@crud89
Extent buffer and texture binding.
985e3e3 
This should implement #51 for the DirectX 12 back-end.
@crud89
Implement basic mip-map generation workflow.
07f07bd
@crud89
Allow resources to be marked as writable.
c88681c
@crud89
Change compute pipeline interface to support mip map generation.
ed1d1cc
@crud89
Fix sampler LOD clipping.
d1a0641
@crud89
Update documentation on how to create buffers.
a09fd5c
@crud89
Moved image and buffer views into descriptor set.
4853ed3 
This should properly implement #51 for the Vulkan backend.
@crud89
Refactor Vulkan compute pipeline interface.
caba076
@crud89
Use proper view types for image arrays.
455c5c9
@crud89
Implement writable member for Vulkan buffers and images.
0e29ed4
@crud89
Don't re-create image views for render targets each frame.
ca2ba35
@crud89
Don't reserve, but resize the descriptor ranges array.
f71c704
@crud89 crud89 marked this pull request as ready for review July 23, 2021 15:35
@crud89 crud89 merged commit 81b6f8b into main Jul 23, 2021
@crud89 crud89 deleted the mip-map-generation branch July 23, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crud89 crud89

Labels
Module: DX12 ❎ The issue involves the DX12 backend. Module: Vulkan 🌋 The issue involves the Vulkan backend. Priority: Medium A issue with normal priority. Type: Feature Request New feature or request. Type: Requirement An implementation is required before the next release.
Projects
LiteFX
Archived in project
Milestone
Alpha #02
Development

Successfully merging this pull request may close these issues.

Decouple descriptors from resources Improve storage buffers. Add support for mip-map generation.
1 participant
@crud89