Regression in bag playback #281
Comments
|
Thanks for reporting this and the excellent test case. I'll release a fix shortly. |
janpaul123
pushed a commit
that referenced
this issue
Dec 3, 2019
Changelog: - Now we always show some data in panels upon first load, even if a `seek-to` URL query parameter is not given. - Replaced toggle action with delete action when showing flat selected topics in the 3D panel, and added option to allow different bag topic groups to have different topics (previously topics can't be unchecked unless they are removed from both bag1 and bag2 groups). - Various improvements to playback performance, including using threads for rendering images, a Playback Performance panel, more playback speed options, and other more minor improvements. - Added ability to view and export all point cloud fields upon clicking a point in the 3D panel. - Removed automatic playback when loading Webviz, in all cases. This simplifies Webviz's behavior and implementation. Just press the spacebar to start playback. - Fixed flicker of all panels when seeking. - Fixed bug where unhelpful errors were thrown when an invalid `?seek-to` parameter was given. - Fixed bug where bag data was not properly loaded. #281
|
(If you're interested, this line was the culprit: https://github.com/cruise-automation/webviz/pull/283/files#diff-ff549a830b60d70e1ed51ce42222356fL85-R85) |
janpaul123
added a commit
that referenced
this issue
Dec 3, 2019
Changelog: - Now we always show some data in panels upon first load, even if a `seek-to` URL query parameter is not given. - Replaced toggle action with delete action when showing flat selected topics in the 3D panel, and added option to allow different bag topic groups to have different topics (previously topics can't be unchecked unless they are removed from both bag1 and bag2 groups). - Various improvements to playback performance, including using threads for rendering images, a Playback Performance panel, more playback speed options, and other more minor improvements. - Added ability to view and export all point cloud fields upon clicking a point in the 3D panel. - Removed automatic playback when loading Webviz, in all cases. This simplifies Webviz's behavior and implementation. Just press the spacebar to start playback. - Fixed flicker of all panels when seeking. - Fixed bug where unhelpful errors were thrown when an invalid `?seek-to` parameter was given. - Fixed bug where bag data was not properly loaded. #281
Ah yes, I see, thanks for linking that. Really appreciate the quick response and resolution @janpaul123 👍 . Confirmed the issue is resolved in the latest |
surajhpatil
pushed a commit
to enwaytech/webviz
that referenced
this issue
Dec 31, 2019
Changelog: - Now we always show some data in panels upon first load, even if a `seek-to` URL query parameter is not given. - Replaced toggle action with delete action when showing flat selected topics in the 3D panel, and added option to allow different bag topic groups to have different topics (previously topics can't be unchecked unless they are removed from both bag1 and bag2 groups). - Various improvements to playback performance, including using threads for rendering images, a Playback Performance panel, more playback speed options, and other more minor improvements. - Added ability to view and export all point cloud fields upon clicking a point in the 3D panel. - Removed automatic playback when loading Webviz, in all cases. This simplifies Webviz's behavior and implementation. Just press the spacebar to start playback. - Fixed flicker of all panels when seeking. - Fixed bug where unhelpful errors were thrown when an invalid `?seek-to` parameter was given. - Fixed bug where bag data was not properly loaded. cruise-automation#281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, thanks for open sourcing webviz!
We've noticed a regression in bag playback. For certain bags with gaps in them the playback halts at the start of the gap instead of continuing playback through them:
A minimal bag that reproduces the issue on https://webviz.io/try/ : playback_issue_minimal.bag.gz
Created with the following script: make_bag.py.gz, basically it has 2 seconds of data, then a gap of two seconds, and then 30 seconds more data. If the last data part is 29 seconds the playback / cache mechanism jumps over the gap.
I think this was introduced in #273, commits before this don't have this issue. Looking further at the changes in this PR I identified the these values to affect the behaviour. Changing
BLOCK_SIZE_NSto something larger (say2.0e9) makes the playback work as expected.@janpaul123 commented in the code that the numbers were determined emperically for good performance. So far increasing the block size doesn't seem to affect the performance too much, but I don't know exactly how the caching mechanism works or how this actually prevents the issue from manifesting.
The text was updated successfully, but these errors were encountered: