-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages/webviz-core from internal repo #273
Conversation
Changelog: - Added a new "Flat" mode to the 3D panel topic picker. Now when playing multiple bags in the "Flat" mode, bag1 topics are grouped under `Bag` and bag2 topics are grouped under `Bag 2 /webviz_bag_2`. In the "Flat" mode, you can temporarily toggle the topic's visibility by clicking the eye icon next to the edit icon. This is the first step in the ongoing work to improve multi-bag comparison in the 3D panel. - Sped up local bag reading by decompressing bag chunks ahead of playback. - Added support for negative slices in the topic path syntax, e.g. to get the last element of an array. - Added the ability to plot numerical values in Diagnostics - Detail panel. - Added ability to pan, zoom and do auto zoom in imageView panel. - Clicking on stacked objects is now automatically turned on in the 3D panel when playback is paused. If there are multiple clicked objects, the object id will be displayed in the context menu if available. - Added ability to toggle visibility of Plot panel's legends. - Implemented a workaround to runaway disk usage due to a Chrome bug, which has been causing very slow Webviz start up times. If possible, please clear out your local instance of IndexedDB on Webviz. - Fixed image panel with synchronized markers not loading data when seeking, by increasing the amount of data we load when seeking. - Fixed a `Time should never move backwards` error when seeking. - Fixed negative numbers showing incorrect colors in the State Transitions panel. #271
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many features ⭐️ 🎉
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Not sure if the test is flaky or actually failing, may worth check if something is wrong:
|
@davidswinegar can you look at that test? Both the "before" and "after" look incorrect. |
Changelog: - Added a new "Flat" mode to the 3D panel topic picker. Now when playing multiple bags in the "Flat" mode, bag1 topics are grouped under `Bag` and bag2 topics are grouped under `Bag 2 /webviz_bag_2`. In the "Flat" mode, you can temporarily toggle the topic's visibility by clicking the eye icon next to the edit icon. This is the first step in the ongoing work to improve multi-bag comparison in the 3D panel. - Sped up local bag reading by decompressing bag chunks ahead of playback. - Added support for negative slices in the topic path syntax, e.g. to get the last element of an array. - Added the ability to plot numerical values in Diagnostics - Detail panel. - Added ability to pan, zoom and do auto zoom in imageView panel. - Clicking on stacked objects is now automatically turned on in the 3D panel when playback is paused. If there are multiple clicked objects, the object id will be displayed in the context menu if available. - Added ability to toggle visibility of Plot panel's legends. - Implemented a workaround to runaway disk usage due to a Chrome bug, which has been causing very slow Webviz start up times. If possible, please clear out your local instance of IndexedDB on Webviz. - Fixed image panel with synchronized markers not loading data when seeking, by increasing the amount of data we load when seeking. - Fixed a `Time should never move backwards` error when seeking. - Fixed negative numbers showing incorrect colors in the State Transitions panel. cruise-automation#271
Changelog:
Bag
and bag2 topics are grouped underBag 2 /webviz_bag_2
. In the "Flat" mode, you can temporarily toggle the topic's visibility by clicking the eye icon next to the edit icon. This is the first step in the ongoing work to improve multi-bag comparison in the 3D panel.Time should never move backwards
error when seeking.