Add explanation of how to view a rosbag #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, we also have this in the UI already:
|
|
I knew about the drag n drop part, it was running 'docs' and changing the url to get to the page that allows it that isn't obvious. Having something like |
janpaul123
approved these changes
Dec 3, 2019
|
A lot of this info is also in the main readme: https://github.com/cruise-automation/webviz/blob/master/README.md#developing So I wonder if we can link there instead so they don't get out of date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I couldn't figure out how to load a rosbag until coming across #161
Test plan
I ran
npm run docsand browsed tolocalhost:8080/try, then dragged in a rosbag.Versioning impact
No.