Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] "Create Recording" displays an unhelpful error view when performed on an HTTP Agent #944

Closed
Tracked by #943
andrewazores opened this issue Apr 13, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Current Behavior:

"Recordings > Active > Create" results in an unhelpful error message and notification when the selected target is an HTTP-based Cryostat Agent.

Expected Behavior:

Either there should be no error and the action should work as usual (TODO later on, this needs more consideration on the Agent side), or at least the error message should be more informative about why the action failed.

Screenshots

image

@tthvo
Copy link
Member

tthvo commented Apr 14, 2023

Just wondering how to trace this error message to a meaningful one? Or at least for now, are we having like an special case for http-base target that returns a fixed custom message when any error happens?

@andrewazores
Copy link
Member Author

The proper fix is to return a more useful error from the backend that has some informative error code (not 500), and ideally which also has some structured response body that the client can process.

In the timeframe we have for this release (ie. get done today), I think just handling it on the client side and displaying a specific error view if the target connection URL starts with http is good enough.

@tthvo tthvo moved this to Todo in 2.4.0 release Apr 14, 2023
@tthvo tthvo moved this from Todo to Pushed to 2.4.0 in 2.3.0 release Apr 14, 2023
@andrewazores andrewazores moved this from Todo to Backlog in 2.4.0 release May 23, 2023
@andrewazores andrewazores moved this from Backlog to In Progress in 2.4.0 release Sep 18, 2023
@andrewazores andrewazores self-assigned this Sep 22, 2023
@andrewazores
Copy link
Member Author

Since cryostatio/cryostat-agent#175 and https://github.com/cryostatio/cryostat/pull/1608 , the situation is improved enough that I think this can be considered "done". Perhaps we just need to add some documentation about what HTTP 403 on an Agent target could mean with an error message like this (ie. turn on the writes-enabled config).

image

@github-project-automation github-project-automation bot moved this from In Progress to Done in 2.4.0 release Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Pushed to 2.4.0
Status: Done
Development

No branches or pull requests

2 participants