This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: client-cli history/balance may display outdated information #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Added a warning mentioning that the information may be outdated. One possible improvement is that we can record the time of last synced block and display that in the warning.
devashishdxt
requested review from
yihuang,
tomtau,
calvinaco,
leejw51crypto,
lezzokafka and
linfeng-crypto
leejw51crypto
approved these changes
Feb 11, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 11, 2020
1051: Problem: client-cli history/balance may display outdated information r=tomtau a=devashishdxt Solution: Added a warning mentioning that the information may be outdated. One possible improvement is that we can record the time of last synced block and display that in the warning. Fixes #980. Co-authored-by: Devashish Dixit <devashishdxt@gmail.com>
lezzokafka
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 67.51% 66.81% -0.71%
==========================================
Files 145 147 +2
Lines 18804 19004 +200
==========================================
+ Hits 12696 12697 +1
- Misses 6108 6307 +199
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Added a warning mentioning that the information may be outdated. One possible improvement is that we can record the time of last synced block and display that in the warning. Fixes #980.