This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: uncommitted chain-abci storage changes may persisted (fixes #885) #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rypto-com#885) Solution: for the TX-related ops, added a temporary map in storage: - insertions during delivertx will update the temporary map + insert entry into the current db tx - at commit, the db tx is written and flushed - lookup extended to indicate whether the caller wants to read the uncommitted change (as in delivertx -- e.g. if two transactions in the same block want to spend the same utxo, only the first one is valid, so processing needs to read the uncommitted change from the first one before processing the second one) or committed change (e.g. in queries) added two quick unit tests (the first one used to fail with "buffered_write" -- "buffered_write" was removed, as inserts are kind of buffered writes)
tomtau
requested review from
yihuang,
calvinaco,
devashishdxt,
leejw51crypto and
linfeng-crypto
|
bors try |
tryBuild succeeded |
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 64.39% 64.56% +0.17%
==========================================
Files 148 148
Lines 19389 19429 +40
==========================================
+ Hits 12486 12545 +59
+ Misses 6903 6884 -19
|
yihuang
approved these changes
Feb 24, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 24, 2020
1116: Problem: uncommitted chain-abci storage changes may persisted (fixes #885) r=tomtau a=tomtau Solution: for the TX-related ops, added a temporary map in storage: - insertions during delivertx will update the temporary map + insert entry into the current db tx - at commit, the db tx is written and flushed - lookup extended to indicate whether the caller wants to read the uncommitted change (as in delivertx -- e.g. if two transactions in the same block want to spend the same utxo, only the first one is valid, so processing needs to read the uncommitted change from the first one before processing the second one) or committed change (e.g. in queries) added two quick unit tests (the first one used to fail with "buffered_write" -- "buffered_write" was removed, as inserts are kind of buffered writes) 1117: Problem (Fix #1069): blocks with multiple txs may fail light client app hash check r=tomtau a=yihuang Solution: - Change BTreeMap to IndexMap Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com>
Build failed (retrying...) |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: for the TX-related ops, added a temporary map in storage:
-- e.g. if two transactions in the same block want to spend the same utxo,
only the first one is valid, so processing needs to read the uncommitted change from the first one before processing the second one)
or committed change (e.g. in queries)
added two quick unit tests (the first one used to fail with "buffered_write" -- "buffered_write" was removed, as inserts are kind of buffered writes)