This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: cryptographic library code diverged from "planned" upstream (fixes #1143) #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
requested review from
yihuang,
calvinaco,
devashishdxt,
leejw51crypto and
linfeng-crypto
|
bors try |
tryBuild failed |
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 63.78% 63.83% +0.04%
==========================================
Files 149 149
Lines 19902 19874 -28
==========================================
- Hits 12695 12686 -9
+ Misses 7207 7188 -19
|
yihuang
approved these changes
Mar 2, 2020
|
bors retry |
tryBuild failed |
devashishdxt
approved these changes
Mar 3, 2020
|
bors retry |
tryBuild failed |
|
bors retry |
calvinlauyh
approved these changes
Mar 3, 2020
tomtau
force-pushed
the
upgrade/schnorrsig
branch
from
01993ed
to
28ea5f9
Compare
…ixes crypto-com#1143) Solution: - cherry-picked changes from the planned upstream changes to the *temporary* custom secp256k1 fork - adapted the *temporary* Rust library fork to it - changed chain-core witness structure to use the BIP-340 encoding of public keys - adapted client and tests to it NOTE: the schnorrsig proposal was stabilized as https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki the code wasn't yet merged to upstream, so it's possible that underlying cryptographic API may change (and the corresponding Rust), but the transaction (binary/serialized) payloads will be the same.
tomtau
force-pushed
the
upgrade/schnorrsig
branch
from
28ea5f9
to
59ae2c1
Compare
tryBuild succeeded |
|
bors r+ |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
NOTE:
the schnorrsig proposal was stabilized as https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki
the code wasn't yet merged to upstream, so it's possible that underlying cryptographic API
may change (and the corresponding Rust), but the transaction (binary/serialized) payloads
will be the same.