Problem (Fix #1515): unbond tx don't subtract fee from bonded #1516

yihuang · 2020-04-30T08:43:24Z

Solution:

Fix the bug and add unit test

codecov · 2020-04-30T09:25:05Z

Codecov Report

Merging #1516 into master will increase coverage by 0.02%.
The diff coverage is 92.10%.

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   65.75%   65.77%   +0.02%     
==========================================
  Files         161      161              
  Lines       21789    21808      +19     
==========================================
+ Hits        14328    14345      +17     
- Misses       7461     7463       +2

Impacted Files	Coverage Δ
...work/src/network_ops/default_network_ops_client.rs	`78.03% <66.66%> (-0.22%)`	⬇️
chain-abci/src/app/mod.rs	`83.09% <100.00%> (+0.07%)`	⬆️
chain-abci/src/app/staking_event.rs	`99.37% <100.00%> (+<0.01%)`	⬆️
chain-abci/src/staking/mod.rs	`99.10% <100.00%> (+0.01%)`	⬆️
chain-abci/src/staking/tx.rs	`91.96% <100.00%> (+0.14%)`	⬆️
chain-abci/src/storage/mod.rs	`84.69% <100.00%> (+0.08%)`	⬆️
chain-abci/tests/abci_app.rs	`94.87% <100.00%> (+0.02%)`	⬆️

leejw51crypto

lgtm

tomtau

bors r+

1511: Problem (Fix #1313): light client doesn't verify the fetched staking state r=tomtau a=yihuang Solution: - Add staking_root in sync state - Remove the "account" path in favor of the new "staking" path - Client staking state command add wallet name parameter, and verify staking state and proof against the trusted staking_root in sync state - Need to sync wallet before fetching the new staking state now. (you can still get any staking state without verification by request abci_query API directly) 1516: Problem (Fix #1515): unbond tx don't subtract fee from bonded r=tomtau a=yihuang Solution: - Fix the bug and add unit test Co-authored-by: yihuang <huang@crypto.com>

bors · 2020-05-01T02:30:09Z

Build failed (retrying...):

drone-hw/push

tomtau · 2020-05-01T02:37:51Z

bors retry

bors · 2020-05-01T02:37:52Z

Already running a review

tomtau · 2020-05-01T02:43:43Z

bors r+

1516: Problem (Fix #1515): unbond tx don't subtract fee from bonded r=tomtau a=yihuang Solution: - Fix the bug and add unit test Co-authored-by: yihuang <huang@crypto.com>

bors · 2020-05-01T03:04:07Z

Build failed:

drone-hw/push

tomtau

needs extra sync / wait in multi-node join test?

Traceback (most recent call last):
138	  File "./multinode/join_test.py", line 89, in <module>
139	    txid = rpc.staking.unbond(addr, int(state['bonded']), enckey=enckey, name='target')
140	  File "/drone/src/integration-tests/bot/chainrpc.py", line 208, in unbond
141	    return self.call('staking_unbondStake', [name, enckey or get_enckey()], fix_address(address), str(amount))
142	  File "/drone/src/integration-tests/bot/chainrpc.py", line 68, in call
143	    rsp = request(self.client_rpc_url, method, *args, **kwargs)
144	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/__init__.py", line 8, in request
145	    return HTTPClient(endpoint).request(*args, **kwargs)
146	  File "/drone/src/drone/venv/lib/python3.8/site-packages/apply_defaults/decorators.py", line 13, in wrapper
147	    return function(self, *args, **kwargs)
148	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/client.py", line 229, in request
149	    return self.send(
150	  File "/drone/src/drone/venv/lib/python3.8/site-packages/apply_defaults/decorators.py", line 13, in wrapper
151	    return function(self, *args, **kwargs)
152	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/client.py", line 177, in send
153	    raise ReceivedErrorResponseError(response.data)
154	jsonrpcclient.exceptions.ReceivedErrorResponseError: Invalid input: Staking account does not have enough coins to unbond (synchronizing your wallet may help)

tomtau · 2020-05-01T03:15:18Z

or needs to call

 rpc.staking.unbond(addr, int(state['bonded'] - fee), enckey=enckey, name='target')

instead of

 rpc.staking.unbond(addr, int(state['bonded']), enckey=enckey, name='target')

?

(or something like state['bonded']-min_required+1 ?)

Solution: - Fix the bug and add unit test

yihuang · 2020-05-01T08:17:40Z

or needs to call
 rpc.staking.unbond(addr, int(state['bonded'] - fee), enckey=enckey, name='target')
instead of
 rpc.staking.unbond(addr, int(state['bonded']), enckey=enckey, name='target')
?

(or something like state['bonded']-min_required+1 ?)

Yes, fixed now, drone exec runs successfully locally now.

tomtau · 2020-05-01T08:50:29Z

bors r+

bors · 2020-05-01T09:32:11Z

Build succeeded:

1516: Problem (Fix crypto-com#1515): unbond tx don't subtract fee from bonded r=tomtau a=yihuang Solution: - Fix the bug and add unit test Co-authored-by: yihuang <huang@crypto.com>

yihuang requested review from calvinaco, devashishdxt and tomtau as code owners April 30, 2020 08:43

yihuang force-pushed the issue1515 branch 2 times, most recently from bb4193d to f4300b6 Compare April 30, 2020 09:42

tomtau mentioned this pull request Apr 30, 2020

Problem (Fix #1038): no total supply sanity checks #1514

Merged

leejw51 approved these changes Apr 30, 2020 •

edited

Loading

View reviewed changes

leejw51crypto approved these changes Apr 30, 2020

View reviewed changes

tomtau approved these changes May 1, 2020

View reviewed changes

bors bot added a commit that referenced this pull request May 1, 2020

Merge #1516

56b5cd8

1516: Problem (Fix #1515): unbond tx don't subtract fee from bonded r=tomtau a=yihuang Solution: - Fix the bug and add unit test Co-authored-by: yihuang <huang@crypto.com>

tomtau self-requested a review May 1, 2020 03:09

tomtau suggested changes May 1, 2020

View reviewed changes

Problem (Fix crypto-com#1515): unbond tx don't subtract fee from bonded

9291098

Solution: - Fix the bug and add unit test

yihuang force-pushed the issue1515 branch from f4300b6 to 9291098 Compare May 1, 2020 08:13

yihuang requested a review from tomtau May 1, 2020 08:50

bors bot merged commit 9803e3d into crypto-com:master May 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem (Fix #1515): unbond tx don't subtract fee from bonded #1516

Problem (Fix #1515): unbond tx don't subtract fee from bonded #1516

yihuang commented Apr 30, 2020

codecov bot commented Apr 30, 2020 •

edited

Loading

leejw51crypto left a comment

tomtau left a comment

bors bot commented May 1, 2020

tomtau commented May 1, 2020

bors bot commented May 1, 2020

tomtau commented May 1, 2020

bors bot commented May 1, 2020

tomtau left a comment

tomtau commented May 1, 2020

yihuang commented May 1, 2020

tomtau commented May 1, 2020

bors bot commented May 1, 2020

Problem (Fix #1515): unbond tx don't subtract fee from bonded #1516

Problem (Fix #1515): unbond tx don't subtract fee from bonded #1516

Conversation

yihuang commented Apr 30, 2020

codecov bot commented Apr 30, 2020 • edited Loading

Codecov Report

leejw51crypto left a comment

Choose a reason for hiding this comment

tomtau left a comment

Choose a reason for hiding this comment

bors bot commented May 1, 2020

tomtau commented May 1, 2020

bors bot commented May 1, 2020

tomtau commented May 1, 2020

bors bot commented May 1, 2020

tomtau left a comment

Choose a reason for hiding this comment

tomtau commented May 1, 2020

yihuang commented May 1, 2020

tomtau commented May 1, 2020

bors bot commented May 1, 2020

codecov bot commented Apr 30, 2020 •

edited

Loading