Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: unclear client error message when tx-query not set #736

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 24, 2019

Solution:

  • Include the error message returned by chain-abci.

The error message is: Invalid input: abci query fail: 1, tx query address not set

Solution:
- Include the error message returned by chain-abci.
@devashishdxt
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Dec 24, 2019
736: Problem: unclear client error message when tx-query not set r=devashishdxt a=yihuang

Solution:
- Include the error message returned by chain-abci.

The error message is: `Invalid input: abci query fail: 1, tx query address not set`

Co-authored-by: yihuang <yi.codeplayer@gmail.com>
@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #736 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   69.71%   69.69%   -0.02%     
==========================================
  Files         131      131              
  Lines       16746    16748       +2     
==========================================
- Hits        11674    11673       -1     
- Misses       5072     5075       +3
Impacted Files Coverage Δ
...ient-common/src/tendermint/websocket_rpc_client.rs 0% <0%> (ø) ⬆️
chain-core/src/common/merkle_tree.rs 98.55% <0%> (-0.25%) ⬇️

@bors
Copy link
Contributor

bors bot commented Dec 24, 2019

@bors bors bot merged commit 4f51d59 into crypto-com:master Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants