This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem:(Fix #832) random client failing if node didn't store historical state data #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re historical state data solution: each time when chain-abci start, check the last app states stored in `COL_APP_STATES` to force to store historical state data or not.
linfeng-crypto
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
yihuang
approved these changes
Jan 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 69.17% 69.18% +0.01%
==========================================
Files 132 132
Lines 17184 17190 +6
==========================================
+ Hits 11887 11893 +6
Misses 5297 5297
|
bors bot
added a commit
that referenced
this pull request
Jan 7, 2020
830: Problem(Fix #786): client keeps re-deriving hardened key r=tomtau a=yihuang Solution: - derive hmaced-keys only when create wallet, client pass it around. * Use blake2 of wallet name as salt of argon2. 841: Problem: User may enter same view key multiple times in client-cli r=tomtau a=devashishdxt Solution: Used `BTreeSet` instead of `Vec`. Fixes #840 843: Problem:(Fix #832) random client failing if node didn't store historical state data r=tomtau a=linfeng-crypto issue: #832 solution: each time when chain-abci start, check the last app states stored in `COL_APP_STATES` to force to store historical state data or not. Co-authored-by: yihuang <yi.codeplayer@gmail.com> Co-authored-by: Devashish Dixit <devashish@crypto.com> Co-authored-by: linfeng <linfeng@crypto.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #832
solution: each time when chain-abci start, check the last app states stored in
COL_APP_STATESto force to store historical state data or not.