Problem: (#12)mnemonic field is accidentally deleted in accounts generation

[allthatjazzleo]

Solution: adding back mnemonic field

[leejw51crypto]

it should pass integration test
i'm checking on it

[leejw51crypto]

also, check line 255: # create validator account
self.create_account("validator", i, mnemonic)

create_account is used like above, need to change this line or other code.

[leejw51crypto]

change pyproject.toml like this
to test

for example)

• from

[tool.poetry.dependencies]
pystarport = "^0.2.1"

• to

[tool.poetry.dependencies]
pystarport = { git="https://github.com/crypto-com/pystarport.git", branch= "issue-12" }

[leejw51crypto]

make nix-integration-test

integration test passed

[leejw51crypto]

also for api design perspective,
how about giving mnemonics as argument instead of node.get("mnemonic")?
because mnemonic is special, storing is only for testing

if pystarport is used not testing, mnemonics are not stored, and given from user.

[allthatjazzleo]

also, check line 255: # create validator account
self.create_account("validator", i, mnemonic)

create_account is used like above, need to change this line or other code.

For line 255, it is different method from line 691

[leejw51crypto]

yes, that's correct
same name create_account in different classes.
maybe we can do refactoring later. change function name to something different or
separate other file

[leejw51crypto]

lgtm 👍