Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: go 1.20.2 is not used #926

Merged
merged 5 commits into from Mar 14, 2023
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 14, 2023

Solution:

  • update nixpkgs to recent master
  • re-enable coverage report for integration tests

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update nixpkgs to recent master
- re-enable coverage report for integration tests
@yihuang yihuang requested a review from a team as a code owner March 14, 2023 03:48
@yihuang yihuang requested review from calvinaco and leejw51crypto and removed request for a team March 14, 2023 03:48
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #926 (580b74b) into main (2a8e2d4) will decrease coverage by 15.23%.
The diff coverage is n/a.

❗ Current head 580b74b differs from pull request most recent head 70e939d. Consider uploading reports for the commit 70e939d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #926       +/-   ##
===========================================
- Coverage   36.78%   21.56%   -15.23%     
===========================================
  Files          57       48        -9     
  Lines        4170     2991     -1179     
===========================================
- Hits         1534      645      -889     
+ Misses       2460     2285      -175     
+ Partials      176       61      -115     

see 62 files with indirect coverage changes

@yihuang yihuang enabled auto-merge (squash) March 14, 2023 09:55
@yihuang yihuang requested a review from mmsqe March 14, 2023 09:55
@yihuang yihuang merged commit 392eee6 into crypto-org-chain:main Mar 14, 2023
@yihuang yihuang deleted the go1_20_2 branch March 14, 2023 14:08
mmsqe added a commit to mmsqe/cronos that referenced this pull request Mar 16, 2023
* Problem: go 1.20.2 is not used

Solution:
- update nixpkgs to recent master
- re-enable coverage report for integration tests

* enlarge timeout

---------

Co-authored-by: mmsqe <mavis@crypto.com>
mmsqe added a commit that referenced this pull request Mar 16, 2023
* Problem: tx delivery performance is not benchmarked (#916)

Solution:
- add the first benchmark for tx delivery

* Problem: go 1.20.2 is not used (#926)

* Problem: go 1.20.2 is not used

Solution:
- update nixpkgs to recent master
- re-enable coverage report for integration tests

* enlarge timeout

---------

Co-authored-by: mmsqe <mavis@crypto.com>

* Problem: eth tx sender recovery is slow (#928)

* Problem: eth tx sender recovery is slow

Solution:
- update ethermint dependency, do it once in ante handler and cache the result

* fix build

* update upstream

* fix lint

* fix versiondb

* fix memiavl

* fix upgrade integration test

---------

Co-authored-by: mmsqe <mavis@crypto.com>

* fix lint

* fix test

* point to rpc fix only

* no report coverage

---------

Co-authored-by: yihuang <huang@crypto.com>
AleksandM pushed a commit to AleksandM/cronos that referenced this pull request Jan 23, 2024
…n#932)

* Problem: tx delivery performance is not benchmarked (crypto-org-chain#916)

Solution:
- add the first benchmark for tx delivery

* Problem: go 1.20.2 is not used (crypto-org-chain#926)

* Problem: go 1.20.2 is not used

Solution:
- update nixpkgs to recent master
- re-enable coverage report for integration tests

* enlarge timeout

---------

Co-authored-by: mmsqe <mavis@crypto.com>

* Problem: eth tx sender recovery is slow (crypto-org-chain#928)

* Problem: eth tx sender recovery is slow

Solution:
- update ethermint dependency, do it once in ante handler and cache
the result

* fix build

* update upstream

* fix lint

* fix versiondb

* fix memiavl

* fix upgrade integration test

---------

Co-authored-by: mmsqe <mavis@crypto.com>

* fix lint

* fix test

* point to rpc fix only

* no report coverage

---------

Co-authored-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants