New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: ethermint json-rpc fixes are not backported #932
Merged
mmsqe
merged 7 commits into
crypto-org-chain:release/v1.0.x
from
mmsqe:release/v1.0.x-backport
Mar 16, 2023
Merged
Problem: ethermint json-rpc fixes are not backported #932
mmsqe
merged 7 commits into
crypto-org-chain:release/v1.0.x
from
mmsqe:release/v1.0.x-backport
Mar 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#916) Solution: - add the first benchmark for tx delivery
* Problem: go 1.20.2 is not used Solution: - update nixpkgs to recent master - re-enable coverage report for integration tests * enlarge timeout --------- Co-authored-by: mmsqe <mavis@crypto.com>
* Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <mavis@crypto.com>
yihuang
changed the title
Problem: eth tx sender recovery is slow related backport
Problem: eth tx sender recovery speedup is not backported
Mar 16, 2023
mmsqe
requested review from
yihuang and
calvinaco
and removed request for
a team
March 16, 2023 01:32
yihuang
reviewed
Mar 16, 2023
yihuang
changed the title
Problem: eth tx sender recovery speedup is not backported
Problem: ethermint json-rpc fixes are not backported
Mar 16, 2023
yihuang
reviewed
Mar 16, 2023
yihuang
approved these changes
Mar 16, 2023
AleksandM
pushed a commit
to AleksandM/cronos
that referenced
this pull request
Jan 23, 2024
…n#932) * Problem: tx delivery performance is not benchmarked (crypto-org-chain#916) Solution: - add the first benchmark for tx delivery * Problem: go 1.20.2 is not used (crypto-org-chain#926) * Problem: go 1.20.2 is not used Solution: - update nixpkgs to recent master - re-enable coverage report for integration tests * enlarge timeout --------- Co-authored-by: mmsqe <mavis@crypto.com> * Problem: eth tx sender recovery is slow (crypto-org-chain#928) * Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <mavis@crypto.com> * fix lint * fix test * point to rpc fix only * no report coverage --------- Co-authored-by: yihuang <huang@crypto.com>
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more info:
#926
#916
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)