Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ethermint json-rpc fixes are not backported #932

Merged
merged 7 commits into from Mar 16, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 16, 2023

for more info:
#926
#916

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

yihuang and others added 3 commits March 16, 2023 09:13
…#916)

Solution:
- add the first benchmark for tx delivery
* Problem: go 1.20.2 is not used

Solution:
- update nixpkgs to recent master
- re-enable coverage report for integration tests

* enlarge timeout

---------

Co-authored-by: mmsqe <mavis@crypto.com>
* Problem: eth tx sender recovery is slow

Solution:
- update ethermint dependency, do it once in ante handler and cache the result

* fix build

* update upstream

* fix lint

* fix versiondb

* fix memiavl

* fix upgrade integration test

---------

Co-authored-by: mmsqe <mavis@crypto.com>
@yihuang yihuang changed the title Problem: eth tx sender recovery is slow related backport Problem: eth tx sender recovery speedup is not backported Mar 16, 2023
@mmsqe mmsqe marked this pull request as ready for review March 16, 2023 01:32
@mmsqe mmsqe requested a review from a team as a code owner March 16, 2023 01:32
@mmsqe mmsqe requested review from yihuang and calvinaco and removed request for a team March 16, 2023 01:32
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang changed the title Problem: eth tx sender recovery speedup is not backported Problem: ethermint json-rpc fixes are not backported Mar 16, 2023
.github/workflows/test.yml Outdated Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge (squash) March 16, 2023 03:51
@mmsqe mmsqe merged commit efd570d into crypto-org-chain:release/v1.0.x Mar 16, 2023
AleksandM pushed a commit to AleksandM/cronos that referenced this pull request Jan 23, 2024
…n#932)

* Problem: tx delivery performance is not benchmarked (crypto-org-chain#916)

Solution:
- add the first benchmark for tx delivery

* Problem: go 1.20.2 is not used (crypto-org-chain#926)

* Problem: go 1.20.2 is not used

Solution:
- update nixpkgs to recent master
- re-enable coverage report for integration tests

* enlarge timeout

---------

Co-authored-by: mmsqe <mavis@crypto.com>

* Problem: eth tx sender recovery is slow (crypto-org-chain#928)

* Problem: eth tx sender recovery is slow

Solution:
- update ethermint dependency, do it once in ante handler and cache
the result

* fix build

* update upstream

* fix lint

* fix versiondb

* fix memiavl

* fix upgrade integration test

---------

Co-authored-by: mmsqe <mavis@crypto.com>

* fix lint

* fix test

* point to rpc fix only

* no report coverage

---------

Co-authored-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants