New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: eth tx sender recovery is slow #928
Conversation
Solution: - update ethermint dependency, do it once in ante handler and cache the result
Codecov Report
@@ Coverage Diff @@
## main #928 +/- ##
===========================================
+ Coverage 21.56% 37.50% +15.93%
===========================================
Files 48 75 +27
Lines 2991 5557 +2566
===========================================
+ Hits 645 2084 +1439
- Misses 2285 3251 +966
- Partials 61 222 +161
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, upgrade test fails
I see, also looking at it. |
not sure why get |
we have something wrong in upgrade handler, and that's the exact mistake that's checked in new sdk version ;D |
should be fixed, let's see. |
* Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <mavis@crypto.com>
* Problem: tx delivery performance is not benchmarked (#916) Solution: - add the first benchmark for tx delivery * Problem: go 1.20.2 is not used (#926) * Problem: go 1.20.2 is not used Solution: - update nixpkgs to recent master - re-enable coverage report for integration tests * enlarge timeout --------- Co-authored-by: mmsqe <mavis@crypto.com> * Problem: eth tx sender recovery is slow (#928) * Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <mavis@crypto.com> * fix lint * fix test * point to rpc fix only * no report coverage --------- Co-authored-by: yihuang <huang@crypto.com>
…n#932) * Problem: tx delivery performance is not benchmarked (crypto-org-chain#916) Solution: - add the first benchmark for tx delivery * Problem: go 1.20.2 is not used (crypto-org-chain#926) * Problem: go 1.20.2 is not used Solution: - update nixpkgs to recent master - re-enable coverage report for integration tests * enlarge timeout --------- Co-authored-by: mmsqe <mavis@crypto.com> * Problem: eth tx sender recovery is slow (crypto-org-chain#928) * Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <mavis@crypto.com> * fix lint * fix test * point to rpc fix only * no report coverage --------- Co-authored-by: yihuang <huang@crypto.com>
Solution:
Benchmark result improve from 1.3s -> 0.9s, 1k+ erc20 transfer TPS achived in this benchmark ;D
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)