-
-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrations API 1.1.0 #2096
Integrations API 1.1.0 #2096
Conversation
Changes from #2101 should be integrated here as well, once it gets merged. |
# Conflicts: # src/main/java/org/cryptomator/ui/traymenu/TrayMenuController.java
# Conflicts: # pom.xml # src/main/java/org/cryptomator/ui/launcher/UiLauncherModule.java # src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java # src/main/java/org/cryptomator/ui/traymenu/TrayMenuController.java # src/main/resources/license/THIRD-PARTY.txt
src/main/java/org/cryptomator/ui/traymenu/AwtTrayMenuController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, forgot the unused import thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more unused imports reported by sonar cloud: In class FxApplication
and TrayMenuComponent
[ci skip]
# Conflicts: # src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like how the plugin dir is now resolved: Define some undocumented property which is used by an underlying library and not directly in the app. From my point of view it would have been nicer, if we could read the property here (app) and hand it over the library. It would be easier to read and understand code and bugs.
Nonetheless, since I can't present a different approach, you are good to go.
# Conflicts: # src/main/java/org/cryptomator/ui/fxapp/FxApplication.java # src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java
# Conflicts: # pom.xml
Kudos, SonarCloud Quality Gate passed! |
This updates the integration API and makes the AWT tray menu implement the new tray menu API, so it will now only be used as a fallback, if no better tray menu implementation is available.