Integrations API 1.1.0 #2096
Merged
Integrations API 1.1.0 #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes from #2101 should be integrated here as well, once it gets merged. |
# Conflicts: # src/main/java/org/cryptomator/ui/traymenu/TrayMenuController.java
2 tasks
# Conflicts: # pom.xml # src/main/java/org/cryptomator/ui/launcher/UiLauncherModule.java # src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java # src/main/java/org/cryptomator/ui/traymenu/TrayMenuController.java # src/main/resources/license/THIRD-PARTY.txt
infeo
approved these changes
Apr 4, 2022
src/main/java/org/cryptomator/ui/traymenu/AwtTrayMenuController.java
Outdated
Show resolved
Hide resolved
infeo
requested changes
Apr 4, 2022
infeo
requested changes
Apr 4, 2022
[ci skip]
# Conflicts: # src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java
infeo
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
I don't like how the plugin dir is now resolved: Define some undocumented property which is used by an underlying library and not directly in the app. From my point of view it would have been nicer, if we could read the property here (app) and hand it over the library. It would be easier to read and understand code and bugs.
Nonetheless, since I can't present a different approach, you are good to go.
# Conflicts: # src/main/java/org/cryptomator/ui/fxapp/FxApplication.java # src/main/java/org/cryptomator/ui/preferences/GeneralPreferencesController.java
# Conflicts: # pom.xml
|
Kudos, SonarCloud Quality Gate passed! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the integration API and makes the AWT tray menu implement the new tray menu API, so it will now only be used as a fallback, if no better tray menu implementation is available.