-
-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show vault locked/unlocked state in the vault title in the tray menu #2101
Show vault locked/unlocked state in the vault title in the tray menu #2101
Conversation
Please take note that the CI |
@kevinstsauveur Thanks for the PR! We are working currently on fixing the CI, the vulnerability message is a false positive (see also jeremylong/DependencyCheck#4177). I checked out the branch locally, everything seems to work. @tobihagemann What do you say about using |
…lt-state-in-title-tray
Sorry for the late response. I've been thinking about this every now and then. To be honest, I would prefer a solution that doesn't look like from 1997 but I guess AWT is just that old. Really just ASCII? Even a bullet point But I'd prefer a space between |
It seems like it's working on my side with unicode characters (this would have to be thoroughly tested with other systems, maybe @infeo could give us more insight on this limitation). Here's an example with U+002A This is the result of an exploration of other possibilities without adding markers but playing with the font. First font is italic and the second is bold. I find those two options way less obvious to see and are difficult to differentiate. I prefer prefix. |
Thank you for exploring all the different options! 🚀 My vote is for the first option with a |
According to #1474 (and the blocking java upstream issue), Unicode chars are not supported. I assume that due some windows specialiality the checkmark works (fun fact: also the victory hand ✌️ ). But what the hidden scheme is I cannot say and I doubt it would be a os-independent approach. |
Closes #1583.
Description
This PR adds the unlock status to the name of the vault in the tray. It adds
*
as a prefix to each unlocked vault. I tried it as a suffix like it was described in the issue but the marker is less obvious since the name of each vault is not consistent.With this new feature, it's easier than ever to find exactly which vaults are unlocked with a visual marker in the list.
Example
Here's an example with
testvault
as an unlocked vault andtestvault2
as a locked fault.