Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Color Tone #577

Closed
clayop opened this issue Dec 3, 2015 · 9 comments
Closed

Consistent Color Tone #577

clayop opened this issue Dec 3, 2015 · 9 comments

Comments

@clayop
Copy link
Contributor

clayop commented Dec 3, 2015

Currently three colors categories (green, red, and tortoise(blue)) are used. We need to have consistency in color tone. Maybe needs @cassiopaia 's input.

I personally prefer imitating bitcoinwisdom's color concept. (red/green in chart, and pale red and pale green in buy/sell orders)

@c055
Copy link
Collaborator

c055 commented Dec 3, 2015

Yep.. Currently all chart stuff colors are directly included into the javascript files .. but after we would have export them to scss or somthing kinda .. i don't see any problems to get them consistent

@c055 c055 added the discussion label Dec 3, 2015
@wmbutler
Copy link
Contributor

wmbutler commented Dec 3, 2015

@svk31 has articulated this quite a bit. I like consistency in the shades of red and green as well.

@svk31
Copy link
Contributor

svk31 commented Dec 4, 2015

I'm fine with keeping things more consistent, I do find the turquoise more and more jarring tbh. Not a color guy though so happy to leave that up to cass or wmbutler. Colors for the pricechart are defined in PriceChart.jsx since they have to be in js for highcharts, but I'd appreciate it if you played around with the colors there directly instead of doing mockups because it's hard to get them right in Highcharts.

        let positiveColor = "rgba(110, 193, 5, 0.80)";
        let negativeColor = "rgba(225, 66, 74, 0.80)";

The others are in exchange.scss

@wmbutler
Copy link
Contributor

wmbutler commented Dec 4, 2015

@cassiopaia Since you are working on the inverted color scheme as well, do you want to take it?

@wmbutler wmbutler added this to the 2.0.151216 milestone Dec 4, 2015
@c055
Copy link
Collaborator

c055 commented Dec 5, 2015

yep .. i will go over!

@svk31 svk31 modified the milestones: 2.0.151216, 2.0.151223 Dec 18, 2015
@wmbutler wmbutler modified the milestones: 2.0.160106, 2.0.151223 Dec 29, 2015
@wmbutler
Copy link
Contributor

@cassiopaia placing this in 0106

@wmbutler
Copy link
Contributor

@cassiopaia any progress on this?

@c055
Copy link
Collaborator

c055 commented Jan 11, 2016

nope .. i've to wait till my worker is approved or not .. i can't contribute voluntary or per equity basis anymore .. sry!

@svk31
Copy link
Contributor

svk31 commented Jan 19, 2017

This issue was moved to bitshares/bitshares-ui#25

@svk31 svk31 closed this as completed Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants