-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent Color Tone #577
Comments
Yep.. Currently all chart stuff colors are directly included into the javascript files .. but after we would have export them to scss or somthing kinda .. i don't see any problems to get them consistent |
@svk31 has articulated this quite a bit. I like consistency in the shades of red and green as well. |
I'm fine with keeping things more consistent, I do find the turquoise more and more jarring tbh. Not a color guy though so happy to leave that up to cass or wmbutler. Colors for the pricechart are defined in PriceChart.jsx since they have to be in js for highcharts, but I'd appreciate it if you played around with the colors there directly instead of doing mockups because it's hard to get them right in Highcharts.
The others are in exchange.scss |
@cassiopaia Since you are working on the inverted color scheme as well, do you want to take it? |
yep .. i will go over! |
@cassiopaia placing this in 0106 |
@cassiopaia any progress on this? |
nope .. i've to wait till my worker is approved or not .. i can't contribute voluntary or per equity basis anymore .. sry! |
This issue was moved to bitshares/bitshares-ui#25 |
Currently three colors categories (green, red, and tortoise(blue)) are used. We need to have consistency in color tone. Maybe needs @cassiopaia 's input.
I personally prefer imitating bitcoinwisdom's color concept. (red/green in chart, and pale red and pale green in buy/sell orders)
The text was updated successfully, but these errors were encountered: