Have RbNaCl::Util#check_string check encodings

[tarcieri]

I've been bitten by non-binary encodings repeatedly. This raises
EncodingError if we're given a non-BINARY encoding.

[namelessjon]

Can we add a spec for this? Otherwise, looks good!

[tarcieri]

I added a spec. Gonna go ahead and merge this.

What do you think about releasing 3.0.0?

[Asmod4n]

Would like to see everything of libsodium exposed in a 3.0 release.

On 15.04.2014, at 20:29, Tony Arcieri notifications@github.com wrote:

I added a spec. Gonna go ahead and merge this.

What do you think about releasing 3.0.0?

—
Reply to this email directly or view it on GitHub.

[tarcieri]

@Asmod4n is there something specific you need which isn't exposed? We have most of the major features, aside from the "dangerous" ones people probably shouldn't be using anyway.

Mostly I want to start using the SimpleBox API...

[Asmod4n]

Afaik crypto_shorthash and aes-ctr are missing, but don’t need them @tarcieri

On 15.04.2014, at 20:36, Tony Arcieri notifications@github.com wrote:

@Asmod4n is there something specific you need which isn't exposed? We have most of the major features, aside from the "dangerous" ones people probably shouldn't be using anyway.

Mostly I want to start using the SimpleBox API...

—
Reply to this email directly or view it on GitHub.

[wasifhossain]

since OpenSSL doesn't require the key to be in binary encoding, (hex)digest is usually different for non-binary keys.

non_binary_secret = 'secret'
binary_secret = [non_binary_secret].pack('H*')

data = 'a=1'

## non-binary secret

OpenSSL::HMAC.hexdigest('sha256', non_binary_secret, data)
#=> "82b8b502fa852da323a3e5b1bfb10a043ece1551b5c16576d9a995590596389a"

## binary secret

OpenSSL::HMAC.hexdigest('sha256', binary_secret, data)
#=> "6893231bee54ad8a1ddf7f0aae91ea3ee08e2daf09a322574b4c1e2ef0a7ef8e"

RbNaCl::HMAC::SHA256.auth(binary_secret, data).unpack1('H*')
#=> "6893231bee54ad8a1ddf7f0aae91ea3ee08e2daf09a322574b4c1e2ef0a7ef8e"

Seems like Shopify is also following the non-binary approach: https://shopify.dev/apps/auth/oauth/getting-started#process-through-the-hash-function.

Would you recommend a way that the community could follow. Thank you.

[tarcieri]

@wasifhossain generally I'd recommend Encoding::BINARY

[wasifhossain]

thank you, @tarcieri. we'll try to follow this standard.