Enforce RuboCop and correct existing syntax #117
Conversation
This enables RuboCop by default and fixes the existing offences
| sodium_constant :BOXZEROBYTES | ||
| sodium_constant :BEFORENMBYTES | ||
| sodium_constant :PUBLICKEYBYTES | ||
| sodium_constant :SECRETKEYBYTES, :PRIVATEKEYBYTES |
There was a problem hiding this comment.
Stuff like this with rubocop really bugs me. I think version where they're all aligned to the same vertical is a lot more readable.
There was a problem hiding this comment.
RuboCop is configurable. We can shut this particular one off. And FWIW I agree. This patch brings us close to in-line with the RuboCop defaults, so... let the bikeshedding begin! 😉 Then we can shut off the cops we dislike
There was a problem hiding this comment.
@namelessjon I disabled the SingleSpaceBeforeFirstArg cop and put these back to what they were. Any other objections?
There was a problem hiding this comment.
No, I think the rest is all good!
|
A lot of it makes sense, but some of the stylist choices bug me, and I don't think they help with the readability. On the other hand, being able to push toward shorter methods is good. |
|
If you have no other objections, merge it? 😉 |
Enforce RuboCop and correct existing syntax
|
Done |
This enables RuboCop by default and fixes the existing offences