Raise error on degenerate keys (fixes #152) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the RuboCop errors from @paragonie-scott's #153 PR, adds a test, and adopts a belt-and-suspenders approach by trying to detect degenerate keys eagerly (still also handling errors surfaced from libsodium itself)
tarcieri
force-pushed
the
fix-degenerate-keys
branch
from
7cc5f2f
to
b9e53eb
Compare
tarcieri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Picking up on @paragonie-scott's work from #153)
This fixes the RuboCop errors from @paragonie-scott's #153 PR, adds a test, and adopts a belt-and-suspenders approach by trying to detect degenerate keys eagerly (still also handling errors surfaced from libsodium itself)