Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create missing structural design patterns #4

Closed
veelenga opened this issue Sep 29, 2017 · 6 comments
Closed

Create missing structural design patterns #4

veelenga opened this issue Sep 29, 2017 · 6 comments

Comments

@veelenga
Copy link
Member

Currently there are adapter, bridge, composite and decorator.

To finish the list of structural patterns the following should be added:

Keep in mind, that implementation is thematic, so somehow it should relate to the popular Mortal Kombat game. You may found some ideas in existed implementations...

Note: before you start, install Crystal programming language.

@silverweed
Copy link
Collaborator

I'm willing to contribute to this issue, do you prefer separate pull requests for each patterns or a single one?

@veelenga
Copy link
Member Author

Great 👍 It's up to you!

@silverweed
Copy link
Collaborator

Good :)
I think I'll keep them separate to ease reviewing then.

@veelenga
Copy link
Member Author

veelenga commented Oct 2, 2017

Nice job, thanks a lot. I have added you to the list of contributors 9de5a04

Are you interested in working on missing behavioural patterns? I am going to create two separate issues for this with hacktoberfest label.

@veelenga veelenga closed this as completed Oct 2, 2017
This was referenced Oct 2, 2017
@silverweed
Copy link
Collaborator

Why not? I enjoy writing crystal :)

@veelenga
Copy link
Member Author

veelenga commented Oct 2, 2017

Great, checkout #9 and #10. You may need to leave a comment so anyone else will not ask about assignment.

I added you to the collaborators, so please create branches directly on this repo, not on the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants