Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build is failing on macos because it can't build Ruby #11275

Closed
straight-shoota opened this issue Oct 2, 2021 · 9 comments · Fixed by #11276
Closed

Nightly build is failing on macos because it can't build Ruby #11275

straight-shoota opened this issue Oct 2, 2021 · 9 comments · Fixed by #11276
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure

Comments

@straight-shoota
Copy link
Member

https://app.circleci.com/pipelines/github/crystal-lang/crystal/6938/workflows/19a6d680-05e1-44af-8302-969bbe1efc05/jobs/64236

compiling vm.c
In file included from vm.c:344:
./vm_insnhelper.c:5045:43: error: use of undeclared identifier 'RUBY_FUNCTION_NAME_STRING'
        fprintf(stderr, "%s %s(%d):%p\n", RUBY_FUNCTION_NAME_STRING, bf->name, bf->argc, bf->func_ptr);
...
make: *** [vm.o] Error 1
!!! Compiling ruby 2.7.3 failed!

@straight-shoota
Copy link
Member Author

Looks similar to this: rvm/rvm#5047 (comment)

@straight-shoota
Copy link
Member Author

@bcardiff What's the reason that we're building Ruby ourselves with ruby-install vs. installing Ruby via homebrew, for example?

@straight-shoota
Copy link
Member Author

While investigating this, a different error showed up with openssl. Ruby does not yet work with OpenSSL 3.0 but that's installed via homebrew. This issue is tracked in postmodern/ruby-install#409 and fixed in the latest release of ruby-install (0.8.3). So I suppose we just need to run brew update ruby-install until the update is propagated into the CI runner base system.

@straight-shoota straight-shoota transferred this issue from crystal-lang/distribution-scripts Oct 4, 2021
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure labels Oct 4, 2021
@straight-shoota
Copy link
Member Author

@bcardiff
Copy link
Member

bcardiff commented Oct 4, 2021

I don't expect for the CI to trigger a build to do ruby-install . If that is happening, maybe a brew update is needed or we can change how to get that ruby version. I don't recall nothing more than using a specific ruby version to be as precise as possible when running omnibus. The latest update on omnibus required a bump in ruby version used.

@straight-shoota
Copy link
Member Author

I suppose we could as well install Ruby from brew, pinned to ruby@2.7 and don't build it ourselves?

@beta-ziliani
Copy link
Member

@bcardiff What breaks if we do brew install ruby (no version) and then install bundler from gem?

@bcardiff
Copy link
Member

bcardiff commented Oct 5, 2021

@beta-ziliani that things might break without us changing a thing in the CI due to external updates. It can still happen, but there are higher changes :-). I would rather use pinned ruby versions. This is the way 🤓

@straight-shoota
Copy link
Member Author

+1 to pinned versions (#11282)

But brew install ruby@2.7 would serve that purpose as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants