Parser: Add missing locations of various AST nodes #13452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`foo : Bar` and `baz` in `->(foo : Bar, baz) { }`
`*foo` in `*foo, bar = 1, 2`
`foo: Bar` in `x : {foo: Bar}`
|
Do you think it's possible to make a generated test suite that asserts that all nodes have correct locations? |
|
(that's a separate discussion though, not something that should block this PR or be in it at all) |
|
I've extracted that question to #13453 to cleanly separate from this PR discussion. It's a good one 👍 |
`@foo` in `->@foo.x`
`@[Foo]` in `def x(@[Foo] y) end` The location must be set inside `parse_annotation` for when the latter is called directly instead of indirectly via `parse_atomic`. These direct calls to `parse_annotation` are found in `parse_param`, `parse_lib_body_exp`, and `parse_enum_body_expressions`.
`private def foo` in `enum Foo; private def foo; 1; end; end`
`{Foo, Bar}` in `x : {Foo, Bar}`
straight-shoota
approved these changes
May 15, 2023
HertzDevil
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #11798
I also have a bunch more missing locations added locally but still need to add tests for them. I've prioritized nodes that don't have a start
locationsince in many cases it's possible to infer theend_locationfrom child nodes.