Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: Add missing locations of various AST nodes #13452

Merged
merged 10 commits into from
May 16, 2023
Merged

Parser: Add missing locations of various AST nodes #13452

merged 10 commits into from
May 16, 2023

Commits on May 10, 2023

  1. Add missing location of parameter in proc literal 

    `foo : Bar` and `baz` in `->(foo : Bar, baz) { }`
    @FnControlOption
    FnControlOption committed May 10, 2023
    Configuration menu
    Copy the full SHA
    875aec2 View commit details
    Browse the repository at this point in the history

  2. Add missing location of splat in multiple assignment 

    `*foo` in `*foo, bar = 1, 2`
    @FnControlOption
    FnControlOption committed May 10, 2023
    Configuration menu
    Copy the full SHA
    8be813e View commit details
    Browse the repository at this point in the history

  3. Add missing location of argument in named tuple type 

    `foo: Bar` in `x : {foo: Bar}`
    @FnControlOption
    FnControlOption committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6ace14e View commit details
    Browse the repository at this point in the history

  4. [0] -> .first

    @FnControlOption
    FnControlOption committed May 10, 2023
    Configuration menu
    Copy the full SHA
    865a0d9 View commit details
    Browse the repository at this point in the history

  5. Add location of instance/class variable in proc pointer 

    `@foo` in `->@foo.x`
    @FnControlOption
    FnControlOption committed May 10, 2023
    Configuration menu
    Copy the full SHA
    400447f View commit details
    Browse the repository at this point in the history

  6. Add location of annotation 

    `@[Foo]` in `def x(@[Foo] y) end`

The location must be set inside `parse_annotation` for when the
latter is called directly instead of indirectly via `parse_atomic`.
These direct calls to `parse_annotation` are found in `parse_param`,
`parse_lib_body_exp`, and `parse_enum_body_expressions`.
    @FnControlOption
    FnControlOption committed May 10, 2023
    Configuration menu
    Copy the full SHA
    5e3dab1 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge branch 'master' into parser

    @FnControlOption
    FnControlOption committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0b1a849 View commit details
    Browse the repository at this point in the history

  2. at_end -> def end_location

    @FnControlOption
    FnControlOption committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a8793f4 View commit details
    Browse the repository at this point in the history

  3. Add location of private/protected method/macro in enum 

    `private def foo` in `enum Foo; private def foo; 1; end; end`
    @FnControlOption
    FnControlOption committed May 11, 2023
    Configuration menu
    Copy the full SHA
    9486fa3 View commit details
    Browse the repository at this point in the history

  4. Add location of tuple type 

    `{Foo, Bar}` in `x : {Foo, Bar}`
    @FnControlOption
    FnControlOption committed May 11, 2023
    Configuration menu
    Copy the full SHA
    46ea23c View commit details
    Browse the repository at this point in the history