Merge pull request #1530 from bart1e/no_uppercase_for_public_vars

'Not in UPPER_CASE_WITH_UNDERSCORES' warning for public constant vars removed
crytic · Jan 25, 2023 · 2caf510 · 2caf510
2 parents b6d6294 + 339d661
commit 2caf510
Show file tree

Hide file tree

Showing 10 changed files with 50 additions and 1 deletion.
diff --git a/slither/detectors/naming_convention/naming_convention.py b/slither/detectors/naming_convention/naming_convention.py
@@ -139,7 +139,8 @@ def _detect(self):  # pylint: disable=too-many-branches,too-many-statements
                     # For ERC20 compatibility
                     if var.name in ["symbol", "name", "decimals"]:
                         continue
-
+                    if var.visibility == "public":
+                        continue
                     if not self.is_upper_case_with_underscores(var.name):
                         info = [
                             "Constant ",

diff --git a/tests/detectors/naming-convention/0.4.25/no_warning_for_public_constants.sol b/tests/detectors/naming-convention/0.4.25/no_warning_for_public_constants.sol
@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}
diff --git a/...naming-convention/0.4.25/no_warning_for_public_constants.sol.0.4.25.NamingConvention.json b/...naming-convention/0.4.25/no_warning_for_public_constants.sol.0.4.25.NamingConvention.json
@@ -0,0 +1,3 @@
+[
+    []
+]
diff --git a/tests/detectors/naming-convention/0.5.16/no_warning_for_public_constants.sol b/tests/detectors/naming-convention/0.5.16/no_warning_for_public_constants.sol
@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}
diff --git a/...naming-convention/0.5.16/no_warning_for_public_constants.sol.0.5.16.NamingConvention.json b/...naming-convention/0.5.16/no_warning_for_public_constants.sol.0.5.16.NamingConvention.json
@@ -0,0 +1,3 @@
+[
+    []
+]
diff --git a/tests/detectors/naming-convention/0.6.11/no_warning_for_public_constants.sol b/tests/detectors/naming-convention/0.6.11/no_warning_for_public_constants.sol
@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}
diff --git a/...naming-convention/0.6.11/no_warning_for_public_constants.sol.0.6.11.NamingConvention.json b/...naming-convention/0.6.11/no_warning_for_public_constants.sol.0.6.11.NamingConvention.json
@@ -0,0 +1,3 @@
+[
+    []
+]
diff --git a/tests/detectors/naming-convention/0.7.6/no_warning_for_public_constants.sol b/tests/detectors/naming-convention/0.7.6/no_warning_for_public_constants.sol
@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}
diff --git a/...s/naming-convention/0.7.6/no_warning_for_public_constants.sol.0.7.6.NamingConvention.json b/...s/naming-convention/0.7.6/no_warning_for_public_constants.sol.0.7.6.NamingConvention.json
@@ -0,0 +1,3 @@
+[
+    []
+]
diff --git a/tests/test_detectors.py b/tests/test_detectors.py
@@ -609,6 +609,26 @@ def id_test(test_item: Test):
         "naming_convention.sol",
         "0.7.6",
     ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.4.25",
+    ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.5.16",
+    ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.6.11",
+    ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.7.6",
+    ),
     Test(
         all_detectors.ControlledDelegateCall,
         "controlled_delegatecall.sol",