Modulo can't overflow

[Shungy]

slither/slither/slithir/operations/binary.py

Line 100 in 9779380

BinaryType.MODULO,

Do we consider revert when modulo by zero as overflow? Since can_be_checked_for_overflow is never used internally this is not clear.

[0xalpharush]

I believe modulo can be excluded based on https://blog.soliditylang.org/2020/12/16/solidity-v0.8.0-release-announcement/:

The following operations (including their compound assignment versions like +=) now have checks that they did not have before:

addition (+), subtraction (-), multiplication (*)
increment and decrement (++ / --)
unary negation (-)
exponentiation (**)
division (see below) (/)

Additionally, we are missing unary negation and should implement can_be_checked_for_overflow for unary as well.

slither/slither/core/expressions/unary_operation.py

Line 20 in 3383e39

MINUS_PRE = 8 # for stuff like uint(-1)

[0xalpharush]

We do not need to implement can_be_checked_for_overflow for unary negate because it is converted to a binary operation e.g. -7 -> 0 - 7 and subtraction is included in binop's can_be_checked_for_overflow