Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor source mapping + add new source code APIs #877

Merged
merged 17 commits into from
Aug 4, 2022

Conversation

montyly
Copy link
Member

@montyly montyly commented Jun 23, 2021

  • core.source_mapping.SourceMapping is now a class (fix Rewrite source mapping class #695)
  • Add slither.offset_to_objects to retrieve the object on a given offset (WIP)
  • Add slither.utils.source_mapping APIs to allow retrieving definition/implementations/references informations from an offset (WIP)

- core.source_mapping.SourceMapping is now a class (fix #695)
- Add slither.offset_to_objects to retrieve the object on a given
offset (WIP)
- Add slither.utils.source_mapping APIs to allow retrieving
definition/implementations/references informations from an offset (WIP)

Additionally this PR create a strict order for the detectors tests
output to ease the comparison in case in small changes in the json
output
@montyly montyly changed the title Refactor source mapping + add new API Refactor source mapping + add new source code APIs Jun 23, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2021

This pull request introduces 1 alert and fixes 13 when merging 288deec into cd134c4 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 13 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2021

This pull request introduces 1 alert and fixes 13 when merging 58ae66a into be60c73 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 13 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2021

This pull request introduces 1 alert and fixes 13 when merging 5b7a458 into da326aa - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 13 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request introduces 1 alert and fixes 15 when merging a7d8a42 into 65383b9 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 15 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request introduces 1 alert and fixes 15 when merging aed9604 into 5abe863 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 15 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request introduces 1 alert and fixes 15 when merging 8da99e6 into 5abe863 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 15 for Missing call to `__init__` during object initialization

Add --change-line-prefix flag (replace #1042)
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request introduces 1 alert and fixes 15 when merging d18a3da into 0342506 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 15 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request introduces 1 alert and fixes 15 when merging a5489f5 into 0342506 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 15 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Mar 17, 2022

This pull request introduces 1 alert and fixes 15 when merging 8eb481b into 018d0df - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 15 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2022

This pull request introduces 1 alert and fixes 16 when merging 091fe7a into 3a934a9 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 16 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2022

This pull request introduces 1 alert and fixes 16 when merging 48b5202 into 3a934a9 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 16 for Missing call to `__init__` during object initialization

@montyly
Copy link
Member Author

montyly commented Aug 4, 2022

This PR also adds a new flag, --change-line-prefix, to change the prefix used to display source code (default # - file.sol#1). This can be useful to output to vscode, or other IDE

@montyly montyly merged commit e34fcfa into dev Aug 4, 2022
@montyly montyly deleted the dev-source-mapping-refactor branch August 4, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants