-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ecs improvements3 #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods for SubState class
…tener for the entire substate
…to the original one
…ey already exist for the legacy text
… ones for the TMP_InputField
…hile the primary placeholder is not visible
…ure c# ecs and generate game objects from it that are the views of the underlying ecs and keep up to date with the model
…nd only rotating around the y axis)
…onent) for an input component data
…urate and consumes a lot of time
…s not yet contained in the target list (check will only be done in debug mode)
…ty state on being active or not
…s apply the template changes to themselves and when not
…t demonstrates its API and performance difference to creating objects without pooling
…dy used for a different component there can be a bug where afterwards its old component wants it to be removed
…be unique. Use these classes in the tree traversal logic to detect and prevent loops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 9497 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 03090dc and detected 77 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is