Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating shares #36

Closed
moscicki opened this issue Feb 16, 2017 · 2 comments
Closed

updating shares #36

moscicki opened this issue Feb 16, 2017 · 2 comments

Comments

@moscicki
Copy link
Collaborator

There is no way of updating shares — is this intentional?

@dvh
Copy link

dvh commented Feb 16, 2017

@moscicki it is indeed intentional as the create call is a 'fire and forget' call. The receiving party might have removed the incoming share without notifying the sending party. This could be fixed by returning a 404 Not found or 410 Gone but then I wouldn't see the specific use of an update call. Updating the file (permissions) should be part of the specific protocol i.m.h.o. Updating the share itself could be intended to change the receiving user, name, description or the protocol itself, but once it already has been processed by the receiving party changing the user, name or description doesn't have any impact at all and changing the protocol would make things extremely complex.

I could add a PUT call the /shares/{id} quite easily, but I doubt if it offers a lot of added value.

@michielbdejong
Copy link
Contributor

Related to #107.
Closing as a question that was answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants