Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d.SharedSecret undefined #3677

Closed
michielbdejong opened this issue Feb 22, 2023 · 4 comments
Closed

d.SharedSecret undefined #3677

michielbdejong opened this issue Feb 22, 2023 · 4 comments
Assignees

Comments

@michielbdejong
Copy link
Contributor

This line throws a nil pointer exception when Marie tries to accept a transfer-create from Einstein: https://github.com/cs3org/reva/blame/94ced01208864b66b21d2c54977c6df548d37974/internal/grpc/services/gateway/ocmshareprovider.go#L429

@michielbdejong
Copy link
Contributor Author

CC @gmgigi96 @redblom

@redblom
Copy link
Contributor

redblom commented Feb 22, 2023

See pondersource/sciencemesh-php#159 (comment)

The transfers fail because the protocol is not send with the request (pondersource/sciencemesh-php#159 (comment)).
Let's fix both in one go?

@redblom
Copy link
Contributor

redblom commented Feb 23, 2023

Results of the local regular share tests so far:

  1. In gateway.ocmshareprovider.createOCMReference the secret is extracted in getTransferProtocol through TransferOptions, this should be WebdavOptions. Consider creating a getWebdavProtocol method.
    2. The targetURL created in gateway.ocmshareprovider.createOCMReference has an incorrect format. The host part also contains the idp schema. Subsequently in gateway.webdavstorageprovider.ExtractEndpointInfo the endpoint extraction fails. The host part in the target url should lack the schema.
    Ok, so this is what the ocmshareprovider provider_domain config setting is for. That needs to be set.

Result of local transfer share tests so far:

  1. The transfer protocol is not send with the request, and thus the share will not be recognized as a transfer (see Document rclone setup pondersource/sciencemesh-php#159 (comment)).

@redblom
Copy link
Contributor

redblom commented May 8, 2023

Can be closed. Dealt with in PR #3847.

@gmgigi96 gmgigi96 closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants