Data transfers new ocm impl #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redblom
requested review from
labkode,
gmgigi96,
glpatcern and
a team
as code owners
glpatcern
approved these changes
May 4, 2023
Yes, let's save that for the next CS3APIs upgrade. |
…en accepting an ocm share * set transfer protocol when creating transfer type ocm share * refactor transfer endpoints for new ocm impl * refactor/cleanup gateway.ocmshareprovider.UpdateReceivedOCMShare() code * refactor data transfers folder config * new transfers config setting 'remove_on_cancel' * implement transfer destination path * update datatx example toml * update cli ocm-share-update-received with path flag
redblom
force-pushed
the
datatx-new-ocm-impl
branch
6 times, most recently
from
9d18aa4
to
ed861f8
Compare
redblom
force-pushed
the
datatx-new-ocm-impl
branch
from
ed861f8
to
7e3c9ed
Compare
This was referenced May 8, 2023
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
* * remove unnecessary creation of ocm reference in ocmshareprovider when accepting an ocm share * set transfer protocol when creating transfer type ocm share * refactor transfer endpoints for new ocm impl * refactor/cleanup gateway.ocmshareprovider.UpdateReceivedOCMShare() code * refactor data transfers folder config * new transfers config setting 'remove_on_cancel' * implement transfer destination path * update datatx example toml * update cli ocm-share-update-received with path flag * Add changelog * Add #PR --------- Co-authored-by: Antoon P <antoon@redblom.com>
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* * remove unnecessary creation of ocm reference in ocmshareprovider when accepting an ocm share * set transfer protocol when creating transfer type ocm share * refactor transfer endpoints for new ocm impl * refactor/cleanup gateway.ocmshareprovider.UpdateReceivedOCMShare() code * refactor data transfers folder config * new transfers config setting 'remove_on_cancel' * implement transfer destination path * update datatx example toml * update cli ocm-share-update-received with path flag * Add changelog * Add #PR --------- Co-authored-by: Antoon P <antoon@redblom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns #3846
. remove unnecessary creation of ocm reference in ocmshareprovider when accepting an ocm share
. set transfer protocol when creating transfer type ocm share
. refactor transfer endpoints for new ocm impl
. refactor/cleanup gateway.ocmshareprovider.UpdateReceivedOCMShare() code
. refactor data transfers folder config
. new transfers config setting 'remove_on_cancel'
. implement transfer destination path
. update datatx example toml
. update cli ocm-share-update-received with path flag